forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase #10
Merged
Merged
Rebase #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new api-version of hybrid compute to go SDK * Fix bad output-folder
* add skip metric definition to spec * prettier fix * chnage description
* Add office ATP to Swagger * fixes * merge
* Add Identity to createWorkpace example * correct several places in swagger * add id,name,type to PrivateEndpointConnection * fix lintDiff error * fix CI pipelines * fix sku swagger not aligned with service problem
* tag: package-2020-08 * use package-2020-08-02
… 2019-01-01-preview) (#10603) * #7912260: Add tenant configuration API * Fix version * Fix references * Fix Prettier * Add new file to readme.md * Fix Linter warnings * Add Delete method * Adds suppression to readme * Remove suppression for boolean * Ref to common type instead of redefine generic fields * Fix Prettier * Change resource type to plural and descriptions * Add Tenant configuration list * Fix example position * Fix Prettier * Change version for common types * Use local definition instead of ref common types * Revoke 2 latest commits and return repo to signed off state * Fix Prettier Co-authored-by: Alex Kachanov <alkac@corp.microsoft.com>
Co-authored-by: Haoran Sun <haorsun@microsoft.com>
* Update MySQL flexibleServer swagger to change some APIs * Add BYOK APIs and change primaryServerId to sourceServerId * Rename keys to serverkeys to follow the old naming * Fix 202 response for ServerKey PUT API * Remove CheckVirtualNetworkSubnetUsage operation id * Change LocationBasedCapabilities_List response body
…ResourceMover and … (#10661) * Updated the CSharp SDK namespace to Microsoft.Migrate.RegionMove and updated the output folder to match the folder structure in .NET SDK. * Updated namespace and package names of csharp, go and python * Updates * fix schemas parameter Co-authored-by: Ajay Gupta <ajgupt@microsoft.com> Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
* add required fields for sku object * fix prettier * fix lint errors * fix prettier * fix lint errors * Fix lint errors * fix sdk eorror * add default response * Fix checknameavailability response * fix prettier * add default result for operations * Remove proxy resource definition * supress the provider name check * Remove duplicate Resource definition * removed duplicate tracked resource definition
…#10384) * network/2020-05-01: adding the missing web application firewall files * linking the file * adding examples * code review fixes * ignoring the linter because apparently the networking api's don't follow it..
* Add list and get software to GuestConfiguration * Use newer API version for software * Revert software Swagger spec since these are private preview only * Add Automanage resource provider * Address validation tool errors * spelling add antimalware * Address lint errors * Fix error response * Fix newline * Fix Operations API Lint * Fix operations example * Fix prettier and lint * Address lint and prettier errors * Use common definitions and correct pref enum * Fix parameter * Address comments * Fix update examples * Prettier fix * Fix python md Co-authored-by: Abhinav Ghai <abghai@microsoft.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com>
…eview/2020-09-01-preview (#10706) * Adds base for updating Microsoft.Portal from version preview/2019-01-01-preview to version 2020-09-01-preview * Updates readme * Updates API version in new specs and examples * Microsoft.Portal dashboards 2020-09-01-preview RP version * Adding tenant api * Fixing readme * prettier error fix * fixing path * fixing api version Co-authored-by: Himanshu Chandel <hich@microsoft.com>
* Rough draft of new profile for ignite * Addressing the review comments by updating the api versions * Fixing issues in Eventhub specs paths Co-authored-by: bganapa <bganapa@microsoft.com>
* update swagger for outbound public ip feature * Update samples * prettier all the files * fix typo for 'outboundIPs' & 'publicIPs' properties Co-authored-by: Xuyang Cao <xuycao@microsoft.com>
* Added PrivateEndpointConnection API * fix * updated description * lint fix * update * update * updated examples * reverted the erorrresonse changes * testing supperssion lintdiff errorresponse * suppres lintdiff * lintdiff fixes * correted the typo in readme Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
* Computer Vision 3.1 API version - Changes include model updates only, no API surface change * Update version * Fix readme.go.md * Fix sample version * Fix spelling
* PostgreSql Flexible Server Preview Swagger API changes * updated the readme.md file. * Updated the Python Cli changes for Preview. * Updated the csharp generated sdk output path folder * revert mysql changes * Fixed mysql path issue. * updated the output folder * updated the postgresql output folder path * Fixed lint error * Added data action to the operation.
Co-authored-by: Xiaojin Wang <xiaojwan@microsoft.com>
* mongodb atlas source * update Co-authored-by: Jiaxing Song <jiaxson@microsoft.com>
* Updating eventhub specs path in profile * removing checknamespaceavaialbility as there is no swagger spec * Updating resources api version
* New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Add ADP 2020-07-01-preview * Fix type/prettier * Update readmes * Add az cli; fix Python * Add provisioningState property * Fix Python
* Update issue_assignment.yml * Update pull_request_assignment.yml
* Removed color and imageType from the visualFeature enumeration in the V2 SDK. These weren't referenced in the examples. * Added indexing parameters to the swagger for Cognitive Search * Moved properties under configuration * Removed bad formatting so JSON is valid * Added 3 words to custom-words list * Marking IndexingParameter extra properties as not required * Removed duplicate type definitions with $ref, changed default values to false for failOn* properties, and removed en-us locale from URL * Add swagger spec for indexer execution environment * Change the default value to 'standard' * Updating 2020 API swaggers with IndexingParameters in Cognitive Search * Add swagger spec for indexer execution environment in 2 new API versions * Added default value for queryTimeout parameter * Removing indexing parameter changes from 2019-05-06-preview version of swagger * Removed x-nullable from indexing parameter enums * Removed the required: false since everything is optional/not required by default * Marked batchSize, maxFailedItems, and maxFailedItemsPerBatch as x-nullable * Added x-nullable to configuration parameters * Added indexing parameters to the swagger for Cognitive Search * Moved properties under configuration * Removed bad formatting so JSON is valid * Added 3 words to custom-words list * Marking IndexingParameter extra properties as not required * Removed duplicate type definitions with $ref, changed default values to false for failOn* properties, and removed en-us locale from URL * Add swagger spec for indexer execution environment * Change the default value to 'standard' * Updating 2020 API swaggers with IndexingParameters in Cognitive Search * Add swagger spec for indexer execution environment in 2 new API versions * Added default value for queryTimeout parameter * Removing indexing parameter changes from 2019-05-06-preview version of swagger * Removed x-nullable from indexing parameter enums * Removed the required: false since everything is optional/not required by default * Marked batchSize, maxFailedItems, and maxFailedItemsPerBatch as x-nullable * Added x-nullable to configuration parameters * Removed duplicate x-nullable since someone else also added them * Revert "Added x-nullable to configuration parameters" This reverts commit 732f032. * Added default values for excludedFileNameExtensions and indexedFileNameExtensions * Moved indexing parameters configuration to a separate model not under configuration * Referencing the IndexingParametersConfiguration from configuration Co-authored-by: Arvind Krishnaa Jagannathan <arjagann@microsoft.com>
Co-authored-by: Edwin Diaz <eddiazme@microsoft.com>
* updated apispec * spell error fix * removed dncappid from response * updated apispec * Added appid and endpoint in response * adde controller id in delegated subnet response * updated examples * updated * updated apispec * spell check and prettier fix * spell check fix * updated title same in all files * updated operationid * reverting to new change * addressed review comments * addressed feedback comments * spell check fix * updated readme.md * updated definition name * addressed feedback comments * fixed lint issue
* Update alias in pull_request_assignmeng.yml * Update issue_assignment.yml
Co-authored-by: Himanshu Chandel <hich@microsoft.com>
Remove "Currently the only supported option is GRS (GeoRedundantStorage)" from databases 2019
* Update QnAMaker.json Correct PATCH EndpointSettings response code from 200 to 204 * Update example response set endpoint Update example response set endpoint * Prettier validation fix * required propery validation fix * remove alternateQuestionClusters from example * removed alternateQuestionClusters across the example Need to add it as a whole Active learning swagger update * ModelValidation fixed in example instead of spec - non breaking change
* Adds base for updating Microsoft.StorageSync from version stable/2020-03-01 to version 2020-09-01 * Updates readme * Updates API version in new specs and examples * Fix small issues with API version format in readme.md
add publicNetworkAccess property to datafactory
* added incident alerts and incident bookmarks endpoints * changed definition order * style changes * remove labels * change operation ids * changing ids back Co-authored-by: Moran Raz Mizrahi <t-momizr@microsoft.com>
* Added unmanaged devices quota * Specify format * rename field * Minimum 1000 * Add sentinelWorkspaceResourceIds Co-authored-by: Liran Chen <lirche@microsoft.com> Co-authored-by: Orel Kayam <orkayam@microsoft.com>
Co-authored-by: Vikram Praveen Kumar <vipravee@microsoft.com>
…sion preview/2018-07-15-preview (#10494) * Adding table map params * Changing the map to selected tables for now * Adding prettier changes Co-authored-by: Artyom Pavlichenko <temandr@temaMSFT.redmond.corp.microsoft.com>
* Add sdk_customization.md * Update doc with detail steps * Add packageName in generateOutput * Use propertyNames * Fix logPrefix * Update: add dryRun to collect info, fix typo
* Update pull_request_assignment.yml China National Holiday * Update pull_request_assignment.yml * Update pull_request_assignment.yml
Co-authored-by: Vikram Praveen Kumar <vipravee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.