minor cleanup (#812)

* chore: only track PWA errors when DEBUG is on * chore: remove trace statement
nditech · Jun 3, 2021 · b62e47e · b62e47e
1 parent 6233c60
commit b62e47e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/apollo/pwa/static/js/app.js b/apollo/pwa/static/js/app.js
@@ -2,8 +2,6 @@ window.isUpdateAvailable = new Promise((resolve, reject) => {
   if ('serviceWorker' in navigator) {
     navigator.serviceWorker.register('/pwa/serviceworker.js', {scope: '/pwa/'})
       .then(registration => {
-        console.log('service worker registered successfully with scope:', registration.scope);
-
         registration.onupdatefound = () => {
           const installingWorker = registration.installing;
           installingWorker.onstatechange = () => {

diff --git a/apollo/pwa/views_pwa.py b/apollo/pwa/views_pwa.py
@@ -28,7 +28,7 @@ def index():
     else:
         commit = 'unknown'
 
-    trace_errors = settings.TRACK_PWA_ERRORS
+    trace_errors = settings.DEBUG
     sentry_dsn = settings.SENTRY_DSN or ''
 
     context = {'commit': commit, 'trace_errors': trace_errors}

diff --git a/apollo/settings.py b/apollo/settings.py
@@ -41,8 +41,6 @@
 
 SENTRY_DSN = config('SENTRY_DSN', default=None)
 SENTRY_USER_ATTRS = ['email']
-TRACK_PWA_ERRORS = config(
-    'TRACK_PWA_ERRORS', cast=config.boolean, default=False)
 
 MAIL_SERVER = config('MAIL_SERVER', default=None)
 MAIL_PORT = config('MAIL_PORT', default=None)