Fix memory leak in parser #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asynchronous exception can be delivered between `hexml_document_parse` and `hexml_document_free` or `newForeignPnr` causing a leak. One might think that leak is very unlikely, but that's not correct since `hexml_document_parse` is FFI call, so all async exceptions will be postponed while it's running, and delivered immediately as it returns. So any async exceptions during parsing causes memory leak.
|
Thanks! I'll make a release including this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchronous exception can be delivered between
hexml_document_parseandhexml_document_freeornewForeignPnrcausing a leak.One might think that leak is very unlikely, but that's not true since
hexml_document_parseis FFI call, so all async exceptions will be postponed while it's running, and delivered immediately as it returns. So any async exception during parsing causes memory leak.