Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in parser #18

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Commits on Sep 2, 2024

  1. Fix memory leak in parser

    Asynchronous exception can be delivered between `hexml_document_parse`
    and `hexml_document_free` or `newForeignPnr` causing a leak.
    
    One might think that leak is very unlikely, but that's not correct
    since `hexml_document_parse` is FFI call, so all async exceptions
    will be postponed while it's running, and delivered immediately
    as it returns. So any async exceptions during parsing causes
    memory leak.
    Yuras committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    85259ba View commit details
    Browse the repository at this point in the history