Fix/ci issues #98
Merged
Fix/ci issues #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI isses fixed |
frol
reviewed
Jun 22, 2023
frol
reviewed
Jun 22, 2023
| @@ -27,6 +27,7 @@ jobs: | |||
| with: | |||
| profile: minimal | |||
| toolchain: ${{ env.RUST_MSRV }} | |||
| default: true | |||
There was a problem hiding this comment.
This is a bummer that without this line MSRV (minimum supported Rust version) was not really using the toolchain specified in Cargo.toml, but rather only installed it on a side. Now, MSRV tests fail, which indicate that we need to update the version in Cargo.toml to the version that supports all the necessary features.
frol
requested changes
Jun 22, 2023
There was a problem hiding this comment.
@ghimire007 Please, update MSRV in Cargo.toml to the minimum required one and make sure CI is green
|
@frol MSRV in cargo.toml updated |
|
@ghimire007 Is it really the minimum required version to compile cargo-near? |
|
@frol 1.60.0 is seems to be minimum version required to compile. Cargo.toml now has version 1.60.0 . |
frol
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ci issues related to audit ,clippy and tests fixed