Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make build, abi and util modules public #97

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Conversation

ghimire007
Copy link
Contributor

The build module was made public to access run method which helps in resolving [issue ](near/near-workspaces-rs#230 issue by replacing ) in workspace-rs
by replacing existing build logic with cargo-nears build logic.

Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let’s finish the PR on workspaces-rs side before merging this PR

@ghimire007
Copy link
Contributor Author

PR sent on workspace-rs

@frol
Copy link
Contributor

frol commented Jun 19, 2023

@ghimire007 The CI failures are not related to this PR, but I won't be comfortable cutting a new release without addressing the CI errors. Could you, please, fix issues that are raised by CI (submit a separate PR)? Once that one is merged, we can get back to this one, merge it, and cut a new release.

@frol
Copy link
Contributor

frol commented Jun 23, 2023

CI is fixed in #98, so I am going to merge this one now and #98 will follow immediately

@frol frol merged commit 86ecc77 into near:main Jun 23, 2023
3 of 6 checks passed
@frol frol changed the title Make build , abi and util modules public feat: Make build, abi and util modules public Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants