fix: RUSTSEC-2024-0344 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/node-1.40-rc.1
3 tasks
ailisp
reviewed
Jul 9, 2024
| # TODO: trigger Cargo.lock update for x25519-dalek once they release. | ||
| # This fixes https://rustsec.org/advisories/RUSTSEC-2024-0344 by pointing to a commit that includes the fix. | ||
| # This fix has yet to be propagated to crates.io so we will patch it instead. | ||
| x25519-dalek = { git = "https://github.com/dalek-cryptography/curve25519-dalek", rev = "5b7082bbc8e0b2106ab0d956064f61fa0f393cdc" } |
There was a problem hiding this comment.
Nice fix! Should we also patch it for fastauth
There was a problem hiding this comment.
Nope, fastauth should just be left as-is for now so that we don't break anything
ChaoticTempest
force-pushed
the
phuong/fix/RUSTSEC-2024-0344
branch
from
8f10266 to
e1cf28b
Compare
ChaoticTempest
force-pushed
the
phuong/fix/RUSTSEC-2024-0344
branch
from
e1cf28b to
8e2b323
Compare
|
This PR now also ignores RUSTSEC-2024-0347 due to it only affecting integration tests |
ppca
previously approved these changes
Jul 9, 2024
…x/RUSTSEC-2024-0344
ChaoticTempest
dismissed
ppca’s stale review
The merge-base changed after approval.
ppca
approved these changes
Jul 9, 2024
Terraform Feature Environment Destroy (dev-671)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the vulnerability for RUSTSEC-2024-0344. But ignores two other ones due to it only affecting the CLI and workspaces testing, which isn't vital to deal with for now.