Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RUSTSEC-2024-0344 #671

Merged
merged 15 commits into from
Jul 9, 2024
Merged

fix: RUSTSEC-2024-0344 #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4a9a851
Updated mpc RPC clients to use node 1.40-rc.1
ChaoticTempest Jun 18, 2024
a59f4d4
Merge branch 'develop' of github.com:near/mpc-recovery into phuong/ch…
ChaoticTempest Jun 18, 2024
7c1d7ff
Update node to 1.40
ChaoticTempest Jul 8, 2024
29b3f14
Use datastore 5.0.4
ChaoticTempest Jul 8, 2024
6d44a68
Merge branch 'develop' of github.com:near/mpc-recovery into phuong/ch…
ChaoticTempest Jul 8, 2024
d550381
Bump workspaces
ChaoticTempest Jul 8, 2024
8e3278f
Use near-sdk 5.2.1
ChaoticTempest Jul 8, 2024
baba716
Use node-1.40 lake indexer
ChaoticTempest Jul 9, 2024
eb4c4b4
Merge branch develop
ChaoticTempest Jul 9, 2024
a8e0022
Clippy
ChaoticTempest Jul 9, 2024
58c7c04
Fix node vulnerablity for RUSTSEC-2024-0344
ChaoticTempest Jul 8, 2024
dff21e3
Ignore RUSTSEC-2024-0344 for fastauth
ChaoticTempest Jul 9, 2024
8e2b323
Now ignoring RUSTSEC-2024-0347
ChaoticTempest Jul 9, 2024
c55ab61
Ignore RUSTSEC-2024-0346
ChaoticTempest Jul 9, 2024
657d534
Merge branch 'develop' of github.com:near/mpc-recovery into phuong/fi…
ChaoticTempest Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ jobs:
- name: Run Audit (FastAuth)
working-directory: integration-tests/fastauth
run: |
cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0052 --ignore RUSTSEC-2022-0093 --ignore RUSTSEC-2023-0071 --ignore RUSTSEC-2024-0019
cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0052 --ignore RUSTSEC-2022-0093 --ignore RUSTSEC-2023-0071 --ignore RUSTSEC-2024-0019 --ignore RUSTSEC-2024-0344
- name: Run Audit (Chain Signatures)
# even if previous audit step fails, run this audit step to ensure all crates are audited
if: always()
working-directory: integration-tests/chain-signatures
run: |
cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0052 --ignore RUSTSEC-2022-0093 --ignore RUSTSEC-2023-0071 --ignore RUSTSEC-2024-0019
cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0052 --ignore RUSTSEC-2022-0093 --ignore RUSTSEC-2023-0071 --ignore RUSTSEC-2024-0019 --ignore RUSTSEC-2024-0344 --ignore RUSTSEC-2022-0093 --ignore RUSTSEC-2024-0346 --ignore RUSTSEC-2024-0347
36 changes: 29 additions & 7 deletions chain-signatures/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions chain-signatures/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@ members = [
"node",
]
resolver = "2"

[patch.crates-io]
# TODO: trigger Cargo.lock update for x25519-dalek once they release.
# This fixes https://rustsec.org/advisories/RUSTSEC-2024-0344 by pointing to a commit that includes the fix.
# This fix has yet to be propagated to crates.io so we will patch it instead.
x25519-dalek = { git = "https://github.com/dalek-cryptography/curve25519-dalek", rev = "5b7082bbc8e0b2106ab0d956064f61fa0f393cdc" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Should we also patch it for fastauth

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, fastauth should just be left as-is for now so that we don't break anything

Loading