feat: handle MethodNotFound errors in JsonRpcProvider

[andy-haynes]

Motivation

Currently JsonRpcProvider does not do any error parsing when the error message is on the result key (e.g. response.result rather than the expected response.error). These raw errors are not intuitive to users.

Description

This PR checks for string values of result.error on the RPC response and throws an exception if it matches a known pattern for an RPC error using the existing getErrorTypeFromErrorMessage method. This makes it more consistent with the error handling performed for structured errors.

I don't currently know which other RPC endpoints return errors in this way but if it is possible to enumerate them we can ensure they have the same coverage here.

Before:

After:

Checklist

• Read the contributing guidelines
• Commit messages follow the conventional commits spec
• Performed a self-review of the PR
• Added automated tests
• Manually tested the change

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9f6fa84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[idea404]

Good first step to reducing vagueness in these messages
Will keep an eye out for dev feedback on this going forward in NAJ and WS-JS

[idea404]

Add to CI as well if error_messsages.json is up to date according to nearcore dump
refer to this file on error type matching logic

[idea404]

I'm puzzled as to why tests fail now for test/account_multisig.test.js despite there being no changes there

[denbite]

The idea of having understandable error messages looks great to me and was implemented in #1275 based on the latest version of the library and without merge conflicts

I'd suggest closing this one so we don't leave it out of date

[vikinatora]

Closing as it's been resolved by #1275