-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display user-friendly messages for JSON RPC errors #1275
Conversation
🦋 Changeset detectedLatest commit: 2815f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just adjust the changeset
done |
Hey @denbite, please resolve the CI issues and we're ready to merge! |
@denbite there are still two test errors |
@denbite there are errors again, you can run |
This reverts commit 58bc887.
let's run checks again, this time it will pass |
I had difficulty running tests locally on the M1 chip, but I was able to fix it and opened the Pull Request to merge it |
I believe it should work now, have tested all packages |
@vikinatora do you know if this RPC https://rpc.ci-testnet.near.org is used for running tests here? so I reverted changes back in 2815f1e |
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
Added error parsing to
JsonRpcProvider
when the error message is under theresponse.result
key to prevent users from seeing raw errorsBefore
After
Test Plan
Related issues/PRs
#1028