Adding errors for state rent change #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point, keep old errors and just add new ones.
This was referenced Mar 20, 2020
nearprotocol-bulldozer bot
pushed a commit
to near/nearcore
that referenced
this pull request
Mar 30, 2020
Addresses spec change near/NEPs#41 Associated PR to change nearlib errors - near/near-api-js#270 Test plan --------- All runtime tests pass (removing ones that don't make sense) Tests that remove account when it's under funded still work as expected. TODO: add test for creation w/o funds + transfer and deletion of under funded account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, keep old errors and just add new ones.
Note that our generation pipeline doesn't really support this, so no old classes anymore :(
Added README that actually explains how to re-generate error classes.