feat(runtime): switch to state staking #2272

ilblackdragon · 2020-03-18T10:49:28Z

Addresses spec change near/NEPs#41

Associated PR to change nearlib errors - near/near-api-js#270

Test plan

All runtime tests pass (removing ones that don't make sense)
Tests that remove account when it's under funded still work as expected.
TODO: add test for creation w/o funds + transfer and deletion of under funded account.

Addresses spec change near/NEPs#41 Test plan --------- All runtime tests pass (removing ones that don't make sense) Tests that remove account when it's under funded still work as expected.

gitpod-io · 2020-03-18T10:49:33Z

…hema; remove a warning

MaksymZavershynskyi · 2020-03-18T17:26:23Z

Let's wait with the implementation until we agree with the design here: near/NEPs#40 .

core/primitives/src/account.rs

core/primitives/src/errors.rs

runtime/runtime/src/actions.rs

runtime/runtime/src/verifier.rs

chain/chain/src/error.rs

core/primitives/src/errors.rs

runtime/runtime/src/verifier.rs

runtime/runtime/src/actions.rs

ilblackdragon · 2020-03-20T06:52:49Z

@nearmax Generally, I think spec changes should come with associated code changes after initial discussion - because if the change is dramatic or has huge risk, it's valuable to see that at the spec discussion state. It also clear after even initial implementation what are edge cases that should be added to the spec.

MaksymZavershynskyi · 2020-03-23T23:35:33Z

@nearmax Generally, I think spec changes should come with associated code changes after initial discussion - because if the change is dramatic or has huge risk, it's valuable to see that at the spec discussion state. It also clear after even initial implementation what are edge cases that should be added to the spec.

Okay, do you want to submit spec changes PR or create an issue?

ilblackdragon · 2020-03-27T17:56:16Z

@nearmax Submitted spec change.

frol

Except for the obviously broken migration, LGTM.

storage_paid_at and rent_paid getting default 0 values for RPC responses should not break AppLayer, in my opinion, so we can deprecate the fields when we have a plan of how we do that (tracking issue: #2271)

scripts/migrations/5-preserve-height.py

scripts/migrations/6-state-stake.py

All resolved.

core/primitives/src/errors.rs

core/runtime-configs/src/lib.rs

runtime/runtime-params-estimator/src/cases.rs

runtime/runtime/src/actions.rs

scripts/migrations/6-state-stake.py

runtime/runtime/src/actions.rs

runtime/near-runtime-fees/src/lib.rs

runtime/runtime/src/lib.rs

test-utils/testlib/src/standard_test_cases.rs

evgenykuzyakov

Also, it's possible that we might need to bump balance on all accounts that have code deployed. Otherwise they might be out of balance in the testnet. But it's probably not as bad, because this state is not enforced actually. Which we should do

runtime/near-runtime-fees/src/lib.rs

ilblackdragon · 2020-03-30T22:17:45Z

@evgenykuzyakov Returned back to 100 and made sure in migration that every account has enough balance to cover storage.

MaksymZavershynskyi · 2020-03-30T23:03:31Z

core/primitives/src/errors.rs

-    RentUnpaid {
-        /// An account which is required to pay the rent
+    /// Signer account doesn't have enough balance after transaction.
+    LackBalanceForState {


InsufficientBalanceForState would be a better name.

MaksymZavershynskyi · 2020-03-30T23:17:38Z

runtime/runtime/src/actions.rs

+///  - Err(StorageError::StorageInconsistentState) if account has invalid storage usage or amount/locked.
+///
+/// Read details of state staking https://nomicon.io/Economics/README.html#state-stake
+pub(crate) fn get_insufficient_storage_stake(


I would rename it to check_sufficient_storage_stake.

MaksymZavershynskyi

Approving, assuming the comments are addressed.

…nce it is invalid (#2376) This fixes a broken `pytest/tests/sanity/rpc_state_changes.py`. The test got into a broken state after #2272 ## Test Plan * [x] Make sure that the `pytest/tests/sanity/rpc_state_changes.py` test passes locally

feature(runtime): switch to state staking

9e52b8b

Addresses spec change near/NEPs#41 Test plan --------- All runtime tests pass (removing ones that don't make sense) Tests that remove account when it's under funded still work as expected.

ilblackdragon requested review from evgenykuzyakov and bowenwang1996 March 18, 2020 10:49

ilblackdragon requested review from MaksymZavershynskyi and SkidanovAlex as code owners March 18, 2020 10:49

ilblackdragon added this to the MainNet milestone Mar 18, 2020

ilblackdragon added 2 commits March 18, 2020 03:52

Merge remote-tracking branch 'origin/master' into state-stake

0d0351a

Fix test_validate_transaction_invalid_low_balance test; update rpc sc…

84a805e

…hema; remove a warning

ilblackdragon requested a review from frol as a code owner March 18, 2020 15:44

SkidanovAlex reviewed Mar 18, 2020

View reviewed changes

frol mentioned this pull request Mar 19, 2020

Deprecated RPC fields #2271

Open

3 tasks

Fix challenge change after account binary representation switch

aabb6bc

MaksymZavershynskyi previously requested changes Mar 19, 2020

View reviewed changes

chain/chain/src/error.rs Show resolved Hide resolved

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

runtime/runtime/src/verifier.rs Outdated Show resolved Hide resolved

frol reviewed Mar 20, 2020

View reviewed changes

runtime/runtime/src/actions.rs Outdated Show resolved Hide resolved

runtime/runtime/src/actions.rs Outdated Show resolved Hide resolved

ilblackdragon added 2 commits March 20, 2020 06:09

Merge remote-tracking branch 'origin/master' into state-stake

a5e7b5c

Addressing comments

1af31a6

frol mentioned this pull request Mar 20, 2020

AccountView should return computed balance as balance #1811

Closed

ilblackdragon added 3 commits March 23, 2020 09:53

Merge remote-tracking branch 'origin/master' into state-stake

63e334d

Added migration for state staking

56b4669

Merge remote-tracking branch 'origin/master' into state-stake

28a40b4

ilblackdragon removed this from the MainNet milestone Mar 24, 2020

ilblackdragon added 3 commits March 27, 2020 06:46

Merge remote-tracking branch 'origin/master' into state-stake

e9471e8

Adding couple more tests to show case the logic

099fbc4

Remove account name pricing

7211ff3

ilblackdragon requested a review from MaksymZavershynskyi March 27, 2020 17:56

frol approved these changes Mar 27, 2020

View reviewed changes

scripts/migrations/5-preserve-height.py Show resolved Hide resolved

scripts/migrations/6-state-stake.py Outdated Show resolved Hide resolved

bowenwang1996 approved these changes Mar 28, 2020

View reviewed changes

ilblackdragon added 4 commits March 30, 2020 06:04

Fix migration scripts and migration test

e9af34c

Merge remote-tracking branch 'origin/master' into state-stake

88d2fc4

Merge branch 'master' into state-stake

86b520c

Fix migration script

6962337

evgenykuzyakov requested changes Mar 30, 2020

View reviewed changes

evgenykuzyakov reviewed Mar 30, 2020

View reviewed changes

runtime/runtime/src/actions.rs Show resolved Hide resolved

ilblackdragon added 3 commits March 30, 2020 13:41

NEP #55: remove account deletion in state staking. Addressing comments

8a08241

Move Account::new to test_utils

6960fc6

Merge remote-tracking branch 'origin/master' into state-stake

d4765f2

ilblackdragon requested a review from evgenykuzyakov March 30, 2020 20:57

evgenykuzyakov requested changes Mar 30, 2020

View reviewed changes

runtime/near-runtime-fees/src/lib.rs Outdated Show resolved Hide resolved

runtime/runtime/src/lib.rs Outdated Show resolved Hide resolved

test-utils/testlib/src/standard_test_cases.rs Outdated Show resolved Hide resolved

Address comments

03bcf04

ilblackdragon requested a review from evgenykuzyakov March 30, 2020 21:35

ilblackdragon added the automerge label Mar 30, 2020

Merge refs/heads/master into state-stake

1d775c2

evgenykuzyakov requested changes Mar 30, 2020

View reviewed changes

runtime/near-runtime-fees/src/lib.rs Outdated Show resolved Hide resolved

ilblackdragon requested a review from evgenykuzyakov March 30, 2020 22:16

Addressing comments

7da1047

Merge refs/heads/master into state-stake

2608be4

evgenykuzyakov approved these changes Mar 30, 2020

View reviewed changes

MaksymZavershynskyi reviewed Mar 30, 2020

View reviewed changes

MaksymZavershynskyi approved these changes Mar 30, 2020

View reviewed changes

nearprotocol-bulldozer bot merged commit 050396a into master Mar 30, 2020

nearprotocol-bulldozer bot deleted the state-stake branch March 30, 2020 23:18

frol mentioned this pull request Apr 2, 2020

fix(jsonrpc): Removed a test creating an account without a balance since it is invalid #2376

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(runtime): switch to state staking #2272

feat(runtime): switch to state staking #2272

ilblackdragon commented Mar 18, 2020 •

edited

Loading

gitpod-io bot commented Mar 18, 2020 •

edited

Loading

MaksymZavershynskyi commented Mar 18, 2020

ilblackdragon commented Mar 20, 2020

MaksymZavershynskyi commented Mar 23, 2020

ilblackdragon commented Mar 27, 2020

frol left a comment

evgenykuzyakov left a comment

ilblackdragon commented Mar 30, 2020

MaksymZavershynskyi Mar 30, 2020

MaksymZavershynskyi Mar 30, 2020

MaksymZavershynskyi left a comment

feat(runtime): switch to state staking #2272

feat(runtime): switch to state staking #2272

Conversation

ilblackdragon commented Mar 18, 2020 • edited Loading

Test plan

gitpod-io bot commented Mar 18, 2020 • edited Loading

MaksymZavershynskyi commented Mar 18, 2020

ilblackdragon commented Mar 20, 2020

MaksymZavershynskyi commented Mar 23, 2020

ilblackdragon commented Mar 27, 2020

frol left a comment

Choose a reason for hiding this comment

evgenykuzyakov left a comment

Choose a reason for hiding this comment

ilblackdragon commented Mar 30, 2020

MaksymZavershynskyi Mar 30, 2020

Choose a reason for hiding this comment

MaksymZavershynskyi Mar 30, 2020

Choose a reason for hiding this comment

MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

ilblackdragon commented Mar 18, 2020 •

edited

Loading

gitpod-io bot commented Mar 18, 2020 •

edited

Loading