Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formating issue for a not enough balance error #364

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

janedegtiareva
Copy link
Contributor

@janedegtiareva janedegtiareva commented Jul 21, 2020

Tested: ran a create account txn with balance exceeding balance on masterAccount. Result:

 NotEnoughBalance [Error]: Sender test-1595366732632-786321 does not have enough balance 500000000000000000000000000 for operation costing 500000000004309233884375010
          at Object.parseRpcError (C:\Users\janed\near\near-api-js\lib\utils\rpc_errors.js:38:19)
          at JsonRpcProvider.sendJsonRpc (C:\Users\janed\near\near-api-js\lib\providers\json-rpc-provider.js:146:40)
          at processTicksAndRejections (internal/process/task_queues.js:97:5)
          at Account.signAndSendTransaction (C:\Users\janed\near\near-api-js\lib\account.js:115:22)
          at Object.<anonymous> (C:\Users\janed\near\near-api-js\test\account.test.js:38:5) {
        type: 'NotEnoughBalance',
        balance: '500000000000000000000000000',
        cost: '500000000004309233884375010',
        signer_id: 'test-1595366732632-786321'
      }

This is a fix for #363

@janedegtiareva janedegtiareva requested a review from chadoh as a code owner July 21, 2020 21:27
@janedegtiareva janedegtiareva requested a review from vgrichina July 22, 2020 20:34
Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💐

@janedegtiareva janedegtiareva merged commit 090edb5 into master Jul 22, 2020
@janedegtiareva janedegtiareva deleted the not-enough-balance branch July 22, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants