feat: allow borsh-serialized contract fn arguments #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
allow-borsh-serialization
branch
from
b929507 to
ed2147b
Compare
vgrichina
reviewed
Oct 7, 2020
vgrichina
approved these changes
Oct 7, 2020
|
@chadoh need to fix test failures |
chadoh
force-pushed
the
allow-borsh-serialization
branch
2 times, most recently
from
60be4ff to
c3c69c3
Compare
Let's say you have a `contract` object instantiated in your code, and
the contract it wraps has an `add_person` function which receives a
borsh-serialized struct. The following code now works:
import { serialize } from 'near-api-js/lib/utils/serialize'
class Person {
constructor (proof) {
Object.assign(this, proof)
}
}
const personSchema = new Map([
[Person, {
kind: 'struct',
fields: [
['age', 'u64'],
['name', 'String'],
]
}]
])
const person = new Person({ age: 33, name: 'Jesus' })
contract.add_person(serialize(personSchema, person))
add stronger typing to `nameFunction`
chadoh
force-pushed
the
allow-borsh-serialization
branch
from
c3c69c3 to
c7dc8a9
Compare
|
@vgrichina merged; could you cut a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say you have a
contractobject instantiated in your code, and the contract it wraps has anadd_personfunction which receives a borsh-serialized struct. The following code now works: