Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad-hoc build logic with cargo-near #230

Closed
itegulov opened this issue Nov 2, 2022 · 4 comments · Fixed by #275
Closed

Replace ad-hoc build logic with cargo-near #230

itegulov opened this issue Nov 2, 2022 · 4 comments · Fixed by #275
Assignees

Comments

@itegulov
Copy link
Contributor

itegulov commented Nov 2, 2022

I think the existing cargo build logic can be replaced with cargo-near's public API (apart from being a CLI tool it also comes as a library). Less things to maintain => more better?

@ChaoticTempest
Copy link
Member

wouldn't this require users to install cargo-near themselves first? I guess we can add it to build.rs script, but can it be used directly as a rust library?

@itegulov
Copy link
Contributor Author

itegulov commented Nov 3, 2022

Yeah, it has a lib.rs, so it should be possible to use it directly as a regular library. The API might be awkward though, we haven't paid much attention to its "cli-as-a-library" design.

@ChaoticTempest
Copy link
Member

This should also alleviate the error message problem when unable to compile with cargo build shown in #236

@ghimire007
Copy link
Contributor

@frol As per our offline discussion, I would like work in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants