Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use cargo-near to build project #275

Merged
merged 5 commits into from
Jun 26, 2023
Merged

refactor: Use cargo-near to build project #275

merged 5 commits into from
Jun 26, 2023

Conversation

ghimire007
Copy link
Contributor

@ghimire007 ghimire007 commented Jun 17, 2023

replaced existing build logic to use cargo near to resolve #230

@frol
Copy link
Collaborator

frol commented Jun 19, 2023

@ghimire007 I cleaned up the code even further. This PR is only waiting for a new cargo-near release (crates with git dependencies cannot be published to crates.io), which is blocked on near/cargo-near#97 (comment)

@ghimire007
Copy link
Contributor Author

@frol I have updated project to use cargo-near 0.3.1

Comment on lines +18 to +22
release: true,
embed_abi: true,
doc: false,
color: cargo_near::ColorPreference::Always,
no_abi: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future context, there was no analysis on which flags actually make sense to use, so we just followed the existing setup - a simple release-mode build for wasm target.

@frol frol merged commit c31a955 into near:main Jun 26, 2023
3 checks passed
@frol frol changed the title Enhancement : Use cargo near to build project refactor: Use cargo-near to build project Jun 26, 2023
@frol frol mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ad-hoc build logic with cargo-near
2 participants