Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable missed pytest tests #4552

Closed
1 of 2 tasks
mina86 opened this issue Jul 22, 2021 · 0 comments · Fixed by #4682
Closed
1 of 2 tasks

Enable missed pytest tests #4552

mina86 opened this issue Jul 22, 2021 · 0 comments · Fixed by #4682
Labels
A-CI Area: Continuous Integration A-testing Area: Unit testing / integration testing Node Node team T-node Team: issues relevant to the node experience team

Comments

@mina86
Copy link
Contributor

mina86 commented Jul 22, 2021 •
edited
Loading

@mina86 mina86 added A-CI Area: Continuous Integration A-testing Area: Unit testing / integration testing T-node Team: issues relevant to the node experience team labels Jul 22, 2021
mina86 added a commit to mina86/nearcore that referenced this issue Jul 27, 2021
@mina86
pytest: add a pre-commit check testing if all pytests are enabled
278043d 
Add the scripts/check_pytest.py to the ‘sanity checks’ pre-commit
tests to make sure that all pytest tests are enabled in one of the
nightly/*.txt files.

Because at the moment there are nine files which do not meet that
criteria, add them to nightly/complete_nayduck_set.txt with a comment
documenting the state.

Issue: near#4552
Fixes: near#2736
@mina86 mina86 mentioned this issue Jul 27, 2021
Merged
mina86 added a commit that referenced this issue Jul 27, 2021
@mina86
pytest: add a pre-commit check testing if all pytests are enabled (#4584
8b8fbb5 
)

Add the scripts/check_pytest.py to the ‘sanity checks’ pre-commit
tests to make sure that all pytest tests are enabled in one of the
nightly/*.txt files.

Because at the moment there are nine files which do not meet that
criteria, add them to nightly/complete_nayduck_set.txt with a comment
documenting the state.

Issue: #4552
Fixes: #2736
mina86 added a commit to mina86/nearcore that referenced this issue Jul 28, 2021
@mina86
nayduck: make nayduck.py a library; support ./ in scripts/check_*.py
e3cb826 
nightly/nayduck.py script supports a `./<path>` syntax for including
another file when reading contents of particular file.  (This is akin
to shell’s `source` command or C’s `#include` directive).  Sadly,
neither scripts/check_pytests.py nor scripts/check_nightly.py support
that syntax.

Fix this by making the nayduck.py script easier to import as a library
and use it in the aforementioned scripts.

While at it, do minor cleanups to scripts/check_nightly.py script and
move nightly.py to scripts directory.

Issue: near#2736
Issue: near#4552
@mina86 mina86 mentioned this issue Jul 28, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Jul 28, 2021
@mina86
nayduck: fix ./ handling
cde8109 
Due to bug introduced in previosu commit, inclusion of any `./<path>`
lines in tests file results in the same file being read again rather
than file denoted by <path>.  Fix that.

Issue: near#2736
Issue: near#4552
mina86 added a commit that referenced this issue Jul 28, 2021
@mina86
nayduck: make nayduck.py a library; support ./ in scripts/check_*.py (
b700d29 
#4590)

nightly/nayduck.py script supports a `./<path>` syntax for including
another file when reading contents of particular file.  (This is akin
to shell’s `source` command or C’s `#include` directive).  Sadly,
neither scripts/check_pytests.py nor scripts/check_nightly.py support
that syntax.

Fix this by making the nayduck.py script easier to import as a library
and use it in the aforementioned scripts.

While at it, do minor cleanups to scripts/check_nightly.py script and
move nightly.py to scripts directory.

Issue: #2736
Issue: #4552
mina86 added a commit to mina86/nearcore that referenced this issue Jul 29, 2021
@mina86
nightly: rework nightly/*.txt test lists; include all in nightly.txt
f540828 
Take advantage of the `./<path>` syntax in the NayDuck test lists and group
different tests that belong to the same category into separate files.
With the include syntax they can all be referenced from `nightly.txt` which
is now the file that contains all the tests NayDuck runs every 24 hours.

Issue: Near-One/nayduck#8
Issue: near#4552
@mina86 mina86 mentioned this issue Jul 29, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Jul 29, 2021
@mina86
nightly: rework nightly/*.txt test lists; include all in nightly.txt
d0049c4 
Take advantage of the `./<path>` syntax in the NayDuck test lists and group
different tests that belong to the same category into separate files.
With the include syntax they can all be referenced from `nightly.txt` which
is now the file that contains all the tests NayDuck runs every 24 hours.

Issue: Near-One/nayduck#8
Issue: near#4552
mina86 added a commit that referenced this issue Jul 29, 2021
@mina86
nightly: rework nightly/*.txt test lists; include all in nightly.txt (#…
92e871b 
…4594)

Take advantage of the `./<path>` syntax in the NayDuck test lists and group
different tests that belong to the same category into separate files.
With the include syntax they can all be referenced from `nightly.txt` which
is now the file that contains all the tests NayDuck runs every 24 hours.

Issue: Near-One/nayduck#8
Issue: #4552
mina86 added a commit to mina86/nearcore that referenced this issue Jul 30, 2021
@mina86
nightly: fix saturate_routing_table test description
6cf4f96 
saturate_routing_table test lives in stress directory not sanity directory.

Issue: near#4552
@mina86 mina86 mentioned this issue Jul 30, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Jul 30, 2021
@mina86
nightly: enable three of the passing tests
a108526 
Issue: near#4552
@mina86 mina86 mentioned this issue Jul 30, 2021
Merged
mina86 added a commit that referenced this issue Jul 30, 2021
@mina86
nightly: fix saturate_routing_table test description (#4608)
6b52d2f 
saturate_routing_table test lives in stress directory not sanity directory.

Issue: #4552
mina86 added a commit that referenced this issue Jul 30, 2021
@mina86
nightly: enable three of the passing tests (#4609)
347bb58 
Issue: #4552
@mina86 mina86 mentioned this issue Aug 10, 2021
Closed
mina86 added a commit to mina86/nearcore that referenced this issue Aug 11, 2021
@mina86
nayduck: support reading commented ./<path> include directives
95e1f73 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: near#4362
Issue: near#4552
mina86 added a commit to mina86/nearcore that referenced this issue Aug 11, 2021
@mina86
nayduck: support reading commented ./<path> include directives
e754975 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: near#4362
Issue: near#4552
mina86 added a commit to mina86/nearcore that referenced this issue Aug 11, 2021
@mina86
nayduck: support reading commented ./<path> include directives
cc3fc3d 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: near#4362
Issue: near#4552
mina86 added a commit to mina86/nearcore that referenced this issue Aug 11, 2021
@mina86
nayduck: support reading commented ./<path> include directives
0f5314b 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: near#4362
Issue: near#4552
@mina86 mina86 mentioned this issue Aug 11, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nayduck: support reading commented ./<path> include directives
86e166e 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: near#4362
Issue: near#4552
near-bulldozer bot pushed a commit that referenced this issue Aug 12, 2021
@mina86
nayduck: support reading commented ./<path> include directives (#4672)
a95f2bb 
When check_pytest.py and check_nightly.py read the test list files
handle commented out include directives (i.e. `#./<path>` lines) so
that the include can be commented out with a TODO and the check
scripts will treat files listed in those files as being mentioned.

Issue: #4362
Issue: #4552
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: move disabled tests to their corresponding files
b998661 
Delete `TODO-disabled-4552.txt` file and move the four tests listed there
to files they belong to.  With that also retire issue near#4552 since now all
the tests are tracked in near#4618.

Fixes: near#4552
Issue: near#4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 13, 2021
@mina86
nightly: move disabled tests to their corresponding files
e9801ed 
Delete `TODO-disabled-4552.txt` file and move the four tests listed there
to files they belong to.  With that also retire issue near#4552 since now all
the tests are tracked in near#4618.

Fixes: near#4552
Issue: near#4618
@mina86 mina86 mentioned this issue Aug 13, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Aug 13, 2021
@mina86
nightly: move disabled tests to their corresponding files (#4682)
fd1b848 
Delete `TODO-disabled-4552.txt` file and move the four tests listed there
to files they belong to.  With that also retire issue #4552 since now all
the tests are tracked in #4618.

Fixes: #4552
Issue: #4618
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Continuous Integration A-testing Area: Unit testing / integration testing Node Node team T-node Team: issues relevant to the node experience team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nightly: move disabled tests to their corresponding files mina86/nearcore
2 participants
@mina86 @gmilescu