Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to fix broken NayDuck tests #4618

Open
14 of 22 tasks
mina86 opened this issue Aug 2, 2021 · 1 comment · Fixed by #5035
Open
14 of 22 tasks

Need to fix broken NayDuck tests #4618

mina86 opened this issue Aug 2, 2021 · 1 comment · Fixed by #5035
Labels
A-CI Area: Continuous Integration A-testing Area: Unit testing / integration testing Groomed Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team

Comments

@mina86
Copy link
Contributor

mina86 commented Aug 2, 2021 •
edited
Loading

The following NayDuck tests are currently broken and disabled:

They need to be fixed or deleted if they are no longer needed.
@mina86 mina86 added A-testing Area: Unit testing / integration testing A-CI Area: Continuous Integration T-node Team: issues relevant to the node experience team labels Aug 2, 2021
@mina86 mina86 mentioned this issue Aug 2, 2021
Merged
mina86 added a commit that referenced this issue Aug 2, 2021
@mina86
pytest: remove breaking assert in bridge pytests (#4619)
fdd45e2 
I’ve got seriously no idea what the assertion in git_clone_install was
supposed to check.  Tying the test to particular commit isn’t a good
idea in the first place.  Plus at the moment `eth2near/ethashproof`
isn’t even a submodule in rainbow bridge repository anyway.

Whatever the reason for the assert, it causes the tests to fail.
Removing it improves the situation (but letting the tests progress)
though it doesn’t fix it completely.

Issue: #4618
@mina86 mina86 mentioned this issue Aug 2, 2021
Merged
mina86 added a commit to mina86/rainbow-bridge that referenced this issue Aug 2, 2021
@mina86
ethashproof: move cache.go to cmd/cache directory
4495af3 
This seems to be where the file is supposed to be.  Readme.md refers to
it being there and build.sh expect it there as well.

Issue: near/nearcore#4618
@mina86 mina86 mentioned this issue Aug 2, 2021
Closed
mina86 added a commit that referenced this issue Aug 3, 2021
@mina86
pytest: fix import of configured_logger in bridge tests (#4623)
624a3bc 
This fixes failures such as:

    Traceback (most recent call last):
      File "tests/bridge/multiple_relays.py", line 8, in <module>
        from configured_logger import logger
    ModuleNotFoundError: No module named 'configured_logger'

Issue: #4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 5, 2021
@mina86
nightly: fix test_gc_after_state_sync test
77048e9 
The test name in the `expensive` nightly tests must match exactly
the path of the path otherwise it won’t match any known tests.
The `test_gc_after_state_sync` is in `process_blocks` module thus
it requires `process_blocks::test_gc_after_state_sync` to be used.

Issues: near#4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 5, 2021
@mina86
nightly: fix test_gc_after_state_sync test
3cb3b5e 
The test name in the `expensive` nightly tests must match exactly
the path of the path otherwise it won’t match any known tests.
The `test_gc_after_state_sync` is in `process_blocks` module thus
it requires `process_blocks::test_gc_after_state_sync` to be used.

Issues: near#4618
@mina86 mina86 mentioned this issue Aug 5, 2021
Merged
mina86 added a commit that referenced this issue Aug 6, 2021
@mina86
nightly: fix test_gc_after_state_sync test (#4644)
93d7d8f 
The test name in the `expensive` nightly tests must match exactly
the path of the path otherwise it won’t match any known tests.
The `test_gc_after_state_sync` is in `process_blocks` module thus
it requires `process_blocks::test_gc_after_state_sync` to be used.

Issues: #4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 6, 2021
@mina86
pytest: bridge: make sure rainbow-bridge repository is up to date
b1c9117 
Issue: near#4618
@mina86 mina86 mentioned this issue Aug 6, 2021
Merged
mina86 added a commit that referenced this issue Aug 6, 2021
@mina86
pytest: bridge: make sure rainbow-bridge repository is up to date (#4648
b24e7a4 
)

Issue: #4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 7, 2021
@mina86
pytest: bridge: fix git_clone_install method
dc90cfc 
Swap if bodies in the `git_clone_install` they way thay should be.

Fixes: b24e7a4
Issue: near#4618
@mina86 mina86 mentioned this issue Aug 7, 2021
Merged
mina86 added a commit that referenced this issue Aug 7, 2021
@mina86
pytest: bridge: fix git_clone_install method (#4654)
a50bb8f 
Swap if bodies in the `git_clone_install` they way thay should be.

Fixes: b24e7a4
Issue: #4618
nikurt pushed a commit that referenced this issue Aug 9, 2021
@mina86 @nikurt
nightly: fix test_gc_after_state_sync test (#4644)
1c27505 
The test name in the `expensive` nightly tests must match exactly
the path of the path otherwise it won’t match any known tests.
The `test_gc_after_state_sync` is in `process_blocks` module thus
it requires `process_blocks::test_gc_after_state_sync` to be used.

Issues: #4618
nikurt pushed a commit that referenced this issue Aug 9, 2021
@mina86 @nikurt
pytest: bridge: make sure rainbow-bridge repository is up to date (#4648
6a2a123 
)

Issue: #4618
nikurt pushed a commit that referenced this issue Aug 9, 2021
@mina86 @nikurt
pytest: bridge: fix git_clone_install method (#4654)
9577e1f 
Swap if bodies in the `git_clone_install` they way thay should be.

Fixes: b24e7a4
Issue: #4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: comment out tests which are currently consistently failing
d3953f6 
With NayDuck nightly runs always including some failing tests it’s hard to
uses it for checking whether a change introduced a regression.  Comment out
all the tests which consistently fail so that the nightly runs become
green.

Fixes: near#4362
Issue: near#4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: move disabled tests to their corresponding files
b998661 
Delete `TODO-disabled-4552.txt` file and move the four tests listed there
to files they belong to.  With that also retire issue near#4552 since now all
the tests are tracked in near#4618.

Fixes: near#4552
Issue: near#4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: comment out tests which are currently consistently failing
744d0fa 
With NayDuck nightly runs always including some failing tests it’s hard to
uses it for checking whether a change introduced a regression.  Comment out
all the tests which consistently fail so that the nightly runs become
green.

Fixes: near#4362
Issue: near#4618
@mina86 mina86 mentioned this issue Aug 12, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: comment out tests which are currently consistently failing
5dbf56a 
With NayDuck nightly runs always including some failing tests it’s hard to
uses it for checking whether a change introduced a regression.  Comment out
all the tests which consistently fail so that the nightly runs become
green.

Fixes: near#4362
Issue: near#4618
mina86 added a commit to mina86/nearcore that referenced this issue Aug 12, 2021
@mina86
nightly: comment out tests which are currently consistently failing
ba2552f 
With NayDuck nightly runs always including some failing tests it’s hard to
uses it for checking whether a change introduced a regression.  Comment out
all the tests which consistently fail so that the nightly runs become
green.

Fixes: near#4362
Issue: near#4618
near-bulldozer bot pushed a commit that referenced this issue Aug 13, 2021
@mina86
nightly: comment out tests which are currently consistently failing (#…
4c1a8f6 
…4674)

With NayDuck nightly runs always including some failing tests it’s hard to
uses it for checking whether a change introduced a regression.  Comment out
all the tests which consistently fail so that the nightly runs become
green.

Fixes: #4362
Issue: #4618
@mina86 mina86 mentioned this issue Dec 2, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Dec 2, 2021
@mina86
pytest: kill node process through Popen class and then wait for it
3504217 
This fixes the following warning:

    ../usr/lib/python3.9/subprocess.py:1052: ResourceWarning: subprocess 91224 is still running
      _warn("subprocess %s is still running" % self.pid,

which is caused by LocalNode not waiting for the thread to terminate
after it’s killed.

Issue: near#3186
Issue: near#4618
@mina86 mina86 mentioned this issue Dec 2, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Dec 2, 2021
@mina86
pytest: close stdout and stderr when local node is cleaned up (#5576)
7d80bf0 
This fixes the following warning when trying to run tests with
unittest fixture:

    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stdout' mode='a' encoding='UTF-8'>
    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stderr' mode='a' encoding='UTF-8'>

Issue: #3186
Issue: #4618
near-bulldozer bot pushed a commit that referenced this issue Dec 7, 2021
@mina86
pytest: kill node process through Popen class and then wait for it (#…
7bf068a 
…5578)

This fixes the following warning:

    ../usr/lib/python3.9/subprocess.py:1052: ResourceWarning: subprocess 91224 is still running
      _warn("subprocess %s is still running" % self.pid,

which is caused by LocalNode not waiting for the thread to terminate
after it’s killed.

Issue: #3186
Issue: #4618
@stale
Copy link

stale bot commented Apr 26, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Apr 26, 2022
@exalate-issue-sync exalate-issue-sync bot added T-nodeX and removed T-node Team: issues relevant to the node experience team labels Jun 28, 2022
@akhi3030 akhi3030 removed the S-stale label Jul 8, 2022
@matklad matklad added T-node Team: issues relevant to the node experience team and removed T-nodeX labels Aug 4, 2022
@exalate-issue-sync exalate-issue-sync bot added the P-low Priority: low label Sep 6, 2022
mina86 added a commit to mina86/nearcore that referenced this issue Sep 6, 2022
@mina86
nightly: enable couple tests which are passing
da5a6a1 
Fixes: near#2949
Issue: near#4618
@mina86 mina86 mentioned this issue Sep 6, 2022
Merged
near-bulldozer bot pushed a commit that referenced this issue Sep 7, 2022
@mina86
nightly: enable couple tests which are passing (#7572)
72affb9 
Fixes: #2949
Issue: #4618
nikurt pushed a commit that referenced this issue Sep 7, 2022
@mina86 @nikurt
nightly: enable couple tests which are passing (#7572)
659cc4e 
Fixes: #2949
Issue: #4618
@mina86 mina86 mentioned this issue Sep 30, 2022
Merged
near-bulldozer bot pushed a commit that referenced this issue Oct 3, 2022
@mina86
integration-tests: enable test_tps_regression::test_highload expensiv…
cf5554c 
…e tests (#7738)

Issue: #4618
@mina86 mina86 removed their assignment Oct 27, 2022
nikurt pushed a commit that referenced this issue Nov 9, 2022
@mina86 @nikurt
nightly: enable couple tests which are passing (#7572)
6a94c81 
Fixes: #2949
Issue: #4618
nikurt pushed a commit that referenced this issue Nov 9, 2022
@mina86 @nikurt
integration-tests: enable test_tps_regression::test_highload expensiv…
9b92f1e 
…e tests (#7738)

Issue: #4618
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-CI Area: Continuous Integration A-testing Area: Unit testing / integration testing Groomed Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sync_massive_test and create new for validator near/nearcore
5 participants
@mina86 @gmilescu @matklad @akhi3030 @EgorKulikov