autocmd User AiderOpen #10
Conversation
WalkthroughThe changes introduce enhancements to the Aider plugin configuration in both Vimscript and Lua formats, adding new settings for key mappings and window dimensions. The Changes
Possibly related PRs
Tip Announcements
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedLanguageTool
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| " Set key mappings for the buffer | ||
| execute 'tnoremap <buffer=' . a:args.buf . '> <Esc> <C-\><C-n>' | ||
| execute 'nnoremap <buffer=' . a:args.buf . '> <Esc> :AiderHide<CR>' | ||
| endfunction |
There was a problem hiding this comment.
vimscriptの設定は自分のlua設定をaiderくんに翻訳してもらっただけなのでできればマージ前に試しておいてほしい(他力本願)
There was a problem hiding this comment.
a:args.bufのところが動かないので（あとフォークされたリポジトリに切り替える方法がよくわからなかった）、マージしてから直します。
There was a problem hiding this comment.
なんかgit remote addとかする必要があるかもしれねえ ( ；´。 ｀；)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
README.md (1)
18-18: Consider adding a comma after "Settings" to improve readability.-## Settings ### vimscript +## Settings, ### vimscriptTools
LanguageTool
[typographical] ~18-~18: Consider adding a comma here.
Context: .../denops.vim) ## Settings ### vimscript Please add the following settings to your vimr...(PLEASE_COMMA)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (2 hunks)
Additional context used
LanguageTool
README.md
[typographical] ~18-~18: Consider adding a comma here.
Context: .../denops.vim) ## Settings ### vimscript Please add the following settings to your vimr...(PLEASE_COMMA)
Additional comments not posted (2)
README.md (2)
36-45: LGTM!The new
augroupandautocmdfor handling theUser AiderOpenevent in Vimscript are correctly implemented.The
s:AiderOpenHandlerfunction is also correctly implemented and sets up the necessary key mappings for the buffer.
51-78: LGTM!The new configuration block for the lazy.nvim plugin manager in Lua is correctly implemented and provides a comprehensive setup for the aider.vim plugin.
The global variables and key mappings are correctly defined, and the
autocmdfor handling theUser AiderOpenevent mirrors the functionality defined in the Vimscript section.
| " Set key mappings for the buffer | ||
| execute 'tnoremap <buffer=' . a:args.buf . '> <Esc> <C-\><C-n>' | ||
| execute 'nnoremap <buffer=' . a:args.buf . '> <Esc> :AiderHide<CR>' | ||
| endfunction |
There was a problem hiding this comment.
a:args.bufのところが動かないので（あとフォークされたリポジトリに切り替える方法がよくわからなかった）、マージしてから直します。
| ``` | ||
|
|
||
| ### lua (lazy.nvim) | ||
| Please add the following settings to your lazy settings. |
| @@ -132,12 +60,14 @@ export const buffer = { | |||
| ): Promise<void | undefined | boolean> { | |||
| const aiderBufnr = await getAiderBufferNr(denops); | |||
| if (aiderBufnr) { | |||
| await buffer.openFloatingWindow(denops, aiderBufnr); | |||
| await openFloatingWindow(denops, aiderBufnr); | |||
| await emit(denops, "User", "AiderOpen"); | |||
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation