checkIfAiderBuffer #8

tsukimizake · 2024-09-10T06:29:01Z

getBufferNameを使ってaiderのバッファかどうか確認するcheckIfAiderBufferと、buftypeを見るcheckIfTerminalBufferを追加しました
既存のbuftypeのチェックをしていた場所を基本的にすべてcheckIfAiderBufferに変更し、addCurrentFileでターミナルバッファの場合何もしない処理の部分だけcheckIfTerminalBufferのままにしています
それに合わせていくつかリネームをしています
とりあえず手元ではugatermのターミナルバッファとaiderが混線する不具合が解消しています
あと関係ないけどAiderExitとかAiderSendPromptWithInputとかが動かなくなってそう

Summary by CodeRabbit

New Features
- Introduced enhanced buffer identification for Aider buffers, improving specificity in buffer management.
- Added a new function to check if a buffer is an Aider buffer.
Bug Fixes
- Improved the logic for retrieving buffer numbers, ensuring accurate identification of Aider buffers.
Refactor
- Renamed functions to better reflect their purpose related to Aider buffers, enhancing code clarity.

coderabbitai · 2024-09-10T06:29:12Z

Warning

Rate limit exceeded

@tsukimizake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 7 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4a699d5 and ed3939c.

Walkthrough

The pull request introduces changes to the buffer management logic in the Denops environment, focusing on the transition from terminal buffers to Aider buffers. Key modifications include renaming functions and updating import statements to reflect this new focus. The logic for identifying buffer types has been refined, enhancing clarity and specificity in how buffer information is retrieved and validated.

Changes

Files	Change Summary
`denops/aider/aiderCommand.ts`, `denops/aider/buffer.ts`, `denops/aider/utils.ts`	Renamed `getTerminalBufferNr` to `getAiderBufferNr`, introduced `checkIfAiderBuffer`, and updated related functions to improve buffer identification logic.

Possibly related PRs

silentAiderRun on addCurrentFile if not running #3: The changes in this PR involve modifications to buffer handling logic, including the use of the getAiderBufferNr function, which is directly related to the changes made in the main PR regarding buffer identification and management.
♻️ リファクタリング: Aiderバッファ関連ユーティリティの分離 #5: This PR includes updates to the utils.ts file, which is relevant as it involves the getAiderBufferNr function that was introduced in the main PR, indicating a connection in the utility functions related to buffer management.

Poem

🐇 In the world of Denops, changes abound,
Aider buffers now take the crown.
With clearer checks and functions anew,
We hop along, with joy in our view.
Hooray for the code, let’s give a cheer,
For Aider’s bright future, we hold dear! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tsukimizake · 2024-09-10T06:53:46Z

denops/aider/buffer.ts

+): Promise<boolean> {
+  // aiderバッファの場合 `term://{path}//{pid}:aider --4o --no-auto-commits` のような名前になっている
+  const name = await getBufferName(denops, bufnr);
+  const splitted = name.split(" ");


pathにスペースが含まれていると駄目そうな気がしてきた (家紋)

試してみて気づいたけれどパスにスペースが含まれていると/addするときに2つのファイルと認識されてどちらにしろ変な動作してる

""で囲むとかエスケープするとか対策が必要そうですねえ。
ただ今回のPRの範囲外という気がするので、別途対応しましょう。

ここはterm://で始まってかつ:aiderを含むとかの条件の方がよさそう

nekowasabi

@tsukimizake
LGTM!!

tsukimizake added 4 commits September 10, 2024 12:08

identifyAiderBuffer

b8c526d

use checkIfAiderBuffer on getTerminalBufferNr

d6b9f06

getTerminalBufferNr -> getAiderBufferNr

c7174b7

use getBufferName

d156a08

tsukimizake changed the title ~~getAiderBuffer~~ checkIfAiderBuffer Sep 10, 2024

tsukimizake added 2 commits September 10, 2024 15:33

add comment to checkIfAiderBuffer

4a699d5

update function comment

ed3939c

tsukimizake commented Sep 10, 2024

View reviewed changes

nekowasabi approved these changes Sep 10, 2024

View reviewed changes

nekowasabi merged commit 63fb77f into nekowasabi:main Sep 10, 2024
1 check passed

This was referenced Sep 10, 2024

autocmd User AiderOpen #10

Merged

fix: await sendPromptFromFloatingWindow and sendPromptFromSplitWindow #12

Merged

fix: addCurrentFile in split mode. #13

Merged

This was referenced Sep 30, 2024

Refactor #18

Merged

destruct aiderCommand and buffer object, use import as instead #21

Merged

lint by biome #22

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

checkIfAiderBuffer #8

checkIfAiderBuffer #8

tsukimizake commented Sep 10, 2024 •

edited

Loading

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

tsukimizake Sep 10, 2024

tsukimizake Sep 10, 2024 •

edited

Loading

nekowasabi Sep 10, 2024

tsukimizake Sep 10, 2024

nekowasabi left a comment

checkIfAiderBuffer #8

checkIfAiderBuffer #8

Conversation

tsukimizake commented Sep 10, 2024 • edited Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 10, 2024 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

tsukimizake Sep 10, 2024

Choose a reason for hiding this comment

tsukimizake Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

nekowasabi Sep 10, 2024

Choose a reason for hiding this comment

tsukimizake Sep 10, 2024

Choose a reason for hiding this comment

nekowasabi left a comment

Choose a reason for hiding this comment

tsukimizake commented Sep 10, 2024 •

edited

Loading

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

tsukimizake Sep 10, 2024 •

edited

Loading