Support container removal at exit. Fixes #694 #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbenden this pull request is now in conflict 😩 |
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
==========================================
+ Coverage 49.27% 49.78% +0.51%
==========================================
Files 23 23
Lines 2401 2575 +174
==========================================
+ Hits 1183 1282 +99
- Misses 1090 1150 +60
- Partials 128 143 +15
Continue to review full report at Codecov.
|
|
@jbenden this pull request has failed checks 🛠 |
This patch adds a new command-line flag (`--rm`) to automatically stop workflow container(s), just prior to exit. The default behavior is kept, e.g.: the containers continue running at exit. Fixes: nektos#694 Signed-off-by: Joseph Benden <joe@benden.us>
|
@jbenden this pull request has failed checks 🛠 |
|
I think the failure is caused by something external to the changes in this PR. Could someone help confirm this? Thanks! |
|
It's due to DockerHub pull limit. I'm working on fixing that |
|
@jbenden this pull request has failed checks 🛠 |
|
🎉 |
catthehacker
approved these changes
Jun 10, 2021
cplee
approved these changes
Jun 10, 2021
|
@jbenden this pull request has failed checks 🛠 |
mergify
bot
added
needs-work
catthehacker
pushed a commit
to catthehacker/act-fork
that referenced
this pull request
Nov 14, 2021
Adds option to rebuild local action docker images which is enabled by default Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <me@hackerc.at>
catthehacker
pushed a commit
to catthehacker/act-fork
that referenced
this pull request
Nov 22, 2021
Adds option to rebuild local action docker images which is enabled by default Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <me@hackerc.at>
catthehacker
pushed a commit
to catthehacker/act-fork
that referenced
this pull request
Nov 22, 2021
Adds option to rebuild local action docker images Fixed up README due to missing flags after PR nektos#714 and nektos#716 Signed-off-by: hackercat <me@hackerc.at>
cplee
pushed a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new command-line flag (
--rm) to automaticallystop workflow container(s), just prior to exit. The default
behavior is kept, e.g.: the containers continue running at exit.
Fixes: #694
Signed-off-by: Joseph Benden joe@benden.us