Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for docker image rebuild #878

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Nov 13, 2021

Adds option to rebuild local action docker images
which is disabled by default (old behaviour)

Fixes #715

Signed-off-by: hackercat me@hackerc.at

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #878 (11f18c2) into master (0f04942) will increase coverage by 6.84%.
The diff coverage is 60.99%.

❗ Current head 11f18c2 differs from pull request most recent head 4061ccc. Consider uploading reports for the commit 4061ccc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   49.27%   56.11%   +6.84%     
==========================================
  Files          23       25       +2     
  Lines        2401     3949    +1548     
==========================================
+ Hits         1183     2216    +1033     
- Misses       1090     1531     +441     
- Partials      128      202      +74     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.53% <14.54%> (+3.60%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 58.97% <50.00%> (+58.97%) ⬆️
pkg/container/docker_pull.go 28.35% <58.06%> (+10.17%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/artifacts/server.go 67.32% <67.32%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96cf907...4061ccc. Read the comment docs.

README.md Show resolved Hide resolved
pkg/runner/runner_test.go Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team November 13, 2021 20:41
@catthehacker catthehacker requested a review from a team November 19, 2021 21:59
cmd/root.go Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team November 20, 2021 05:38
Adds option to rebuild local action docker images

Fixed up README due to missing flags after
PR nektos#714 and nektos#716

Signed-off-by: hackercat <me@hackerc.at>
@cplee cplee merged commit 8ad6c07 into nektos:master Nov 24, 2021
@catthehacker catthehacker deleted the cat/feat/rebuild-docker branch November 24, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have to delete action container in order to run new changes
2 participants