feat: add discussions deploy mfe s3 deploy #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
force-pushed
the
jlc/add-discussions-deploy
branch
from
674eb1a to
548f23f
Compare
johanseto
force-pushed
the
jlc/add-discussions-deploy
branch
from
548f23f to
f57148f
Compare
andrey-canon
reviewed
Apr 2, 2024
.github/workflows/deploy-mfe-s3.yml
Outdated
| @@ -0,0 +1,108 @@ | |||
| name: MFE S3 Bucket Deployment 🚀 | |||
|
|
|||
| env: | |||
There was a problem hiding this comment.
I think we can remove this one, also we should do that in app-learning
this is like a cherrypick of this pr in learning. https://github.com/nelc/frontend-app-learning/pull/27/files This is an error generated of the load of paragonTheme plugin.
andrey-canon
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add discussions deploy mfe s3 deploy.
Inspired in https://github.com/nelc/frontend-app-learning/blob/open-release/palm.nelp/.github/workflows/deploy-mfe-s3.yml
How Has This Been Tested?
Configured in stage and already deployed.
Here is the action run.
https://github.com/nelc/frontend-app-discussions/actions/runs/8256247276/job/22584543067?pr=2
After
MFE deployed in cloudfront in stage.
https://d2ri3ndu39l55g.cloudfront.net/discussions/