Jlc/fix env vars #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is like a cherrypick of this pr in learning. https://github.com/nelc/frontend-app-learning/pull/27/files This is an error generated of the load of paragonTheme plugin.
johanseto
force-pushed
the
jlc/fix-env-vars
branch
from
c9bdcb0 to
d3641b2
Compare
johanseto
changed the base branch from
open-rc/palm.nelp
to
jlc/add-discussions-deploy
andrey-canon
approved these changes
Apr 2, 2024
johanseto
added a commit
that referenced
this pull request
Apr 8, 2024
* feat: add discussions deploy mfe s3 deploy * fix: read .env vars for production built (#3) this is like a cherrypick of this pr in learning. https://github.com/nelc/frontend-app-learning/pull/27/files This is an error generated of the load of paragonTheme plugin. * feat: pr recommendation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is like a cherrypick of this pr in learning.
https://github.com/nelc/frontend-app-learning/pull/27/files
This is an error generated by the load of paragonTheme plugin.
This also fix the sitename by default.
Meanwhile, there is no runtime configuration for these items, the favicon, and head-name aka sitename wouldn't be tenant-aware and runtime.
There is a PR opened in the community to fix these items.
openedx#668
How Has This Been Tested?
Check the built process is using the new file, and check the variables are using the defined in
.env.Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist