This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
Add delete address command #817
Merged
shargon
merged 4 commits into
neo-project:master
from
Qiao-Jin:add_delete_address_command
Aug 27, 2021
Merged
Add delete address command #817
shargon
merged 4 commits into
neo-project:master
from
Qiao-Jin:add_delete_address_command
Aug 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
previously approved these changes
Aug 18, 2021
shargon
previously approved these changes
Aug 19, 2021
Jim8y
reviewed
Aug 25, 2021
Jim8y
reviewed
Aug 25, 2021
Co-authored-by: Jinghui Liao <jinghui@wayne.edu>
superboyiii
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK
@shargon Merge? |
shargon
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can delete the file if it was empty? otherwise the code looks good
Never mind. He can still import private key. |
erikzhang
approved these changes
Aug 27, 2021
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #814 (comment)