Sysinfo cleanup #1472
Sysinfo cleanup #1472
Conversation
OskarDamkjaer
force-pushed
the
sysinfo_cleanup
branch
from
820f47f to
c87a944
Compare
OskarDamkjaer
force-pushed
the
sysinfo_cleanup
branch
from
ee49e70 to
170bdb4
Compare
| @@ -34,27 +47,12 @@ jest.mock( | |||
| ) | |||
|
|
|||
| describe('sysinfo component', () => { | |||
| test('should render causal cluster table', () => { | |||
There was a problem hiding this comment.
what's the reason for removing this test?
| @@ -0,0 +1,205 @@ | |||
| /* | |||
There was a problem hiding this comment.
Could we perhaps use git commands to rename this file? As it stands now, it looks like we'll lose the commit history on this file after it was renamed...
There was a problem hiding this comment.
I was thinking a single commit that only renamed would be enough, I'll try git mv!
There was a problem hiding this comment.
Seems to me from this stack overflow thread it doesn't matter if I use git mv instead? https://stackoverflow.com/questions/2314652/is-it-possible-to-move-rename-files-in-git-and-maintain-their-history
| @@ -236,41 +236,3 @@ export const responseHandler = (setState: any) => | |||
| success: true | |||
| }) | |||
| } | |||
|
|
|||
| export const clusterResponseHandler = (setState: any) => | |||
There was a problem hiding this comment.
None of this cluster code was used? We should probably check that things are working properly with a server cluster... :-)
There was a problem hiding this comment.
In the PR description I've linked the PR that motivated this change :)
To understand how the :sysinfo frame works, I've refactored and cleaned it up. This PR doesn't intend change any behaviour.
Changes: