Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sysinfo frame, by reading new neo4j settings #1473

Merged
merged 12 commits into from
Jul 15, 2021
Merged

Fix sysinfo frame, by reading new neo4j settings #1473

merged 12 commits into from
Jul 15, 2021

Conversation

OskarDamkjaer
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer commented Jul 12, 2021 •
edited
Loading

Depends on #1472

Changelist:

  • Fixes :sysinfo running before useDb has been set by rerunning the query when it's set.
  • Adds docs on how the :sysinfo frame works
  • Respects metrics.prefix
  • Respect metrics.namespaces.enabled
  • Adds error message on missing metrics to check the settings
  • Changes default metrics to use metrics that aren't filtered out by default

This task quickly crept in scope and one of the issues I didn't have time to solve properly was collecting the settings through dbMetaDuck. Got a thumbs on from greg on the newly used metrics.

preview at http://blank_sysinfo_on_boot.surge.sh

@OskarDamkjaer OskarDamkjaer changed the title [WIP] Fix sysinfo frame Fix sysinfo frame Jul 14, 2021
@OskarDamkjaer OskarDamkjaer requested a review from jharris4 July 14, 2021 07:25
@OskarDamkjaer OskarDamkjaer force-pushed the blank_sysinfo_on_boot branch from 5ff0d13 to aef92bb Compare July 15, 2021 08:31
@OskarDamkjaer OskarDamkjaer force-pushed the blank_sysinfo_on_boot branch from aef92bb to 45f68e6 Compare July 15, 2021 08:31
jharris4
jharris4 approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jharris4 jharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement on how it was before, nice work!

@OskarDamkjaer
Copy link
Contributor Author

Did some more manual testing of this branch (esp compared to current productino) to make sure the setting are handled properly. It worked well, so merging now

@OskarDamkjaer OskarDamkjaer merged commit 3318941 into neo4j:master Jul 15, 2021
@OskarDamkjaer OskarDamkjaer changed the title Fix sysinfo frame Fix sysinfo frame, by reading new neo4j settings Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharris4 jharris4 jharris4 approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OskarDamkjaer @jharris4 @glindroth