Windows npm issues #159
Windows npm issues #159
Conversation
For some reason, node-gyp never exits if we run `npm` commands without the `--silent` option. Passing `--no-progress --no-color` and/or capturing the output of stderr and stdout doesn't help. This will still make the npm commands fail in case something goes wrong, and won't suppress the node-gyp output when running cargo in verbose mode.
|
r? @jedireza |
|
r+ to the changes, they're simple enough. I wonder what we lose by adding If we get around this [Windows bug] using Maybe we could apply this argument for Windows users only. I only hesitate because we're silencing something that may be helpful when looking at build logs or during development. |
|
I see now that the output of cargo build scripts are suppressed anyways, unless an error occurs. There is a This can be helpful in the case of windows builds hanging since an error hasn't actually occurred yet (process hasn't finished). With this [ |
|
OK, it took a while but the bug has been identified in Rust's So we should just go ahead with the workaround but leave a comment to remove the workaround once the Rust fix has been in long enough. We may want to wait at least a couple of Rust release cycles so people can use older Rusts. |
(Pulled out from #122.)