Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows npm issues #159

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Windows npm issues #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/neon-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ const NPM_COMMAND : &'static str = "npm.cmd";

fn build_object_file() {
// Ensure that all package.json dependencies and dev dependencies are installed.
Command::new(NPM_COMMAND).arg("install").status().ok()
Command::new(NPM_COMMAND).args(&["install", "--silent"]).status().ok()
.expect(r#"failed to run "npm install" for neon-sys"#);

// Run the package.json `configure` script, which invokes `node-gyp configure` from the local node_modules.
Command::new(NPM_COMMAND).arg("run").arg(if debug() { "configure-debug" } else { "configure-release" }).status().ok().unwrap();
Command::new(NPM_COMMAND).args(&["run", "--silent"]).arg(if debug() { "configure-debug" } else { "configure-release" }).status().ok().unwrap();

// Run the package.json `build` script, which invokes `node-gyp build` from the local node_modules.
Command::new(NPM_COMMAND).arg("run").arg(if debug() { "build-debug" } else { "build-release" }).status().ok().unwrap();
Command::new(NPM_COMMAND).args(&["run", "--silent"]).arg(if debug() { "build-debug" } else { "build-release" }).status().ok().unwrap();
}

fn link_library() {
Expand Down