feat(lsp)!: support multiple clients in goto methods #30877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: - neovim#30034 - neovim#17712 - neovim#16363 Closes: - neovim#26936 (but only provides bufnr and method) - neovim#22318 Might fix: neovim#30737
mfussenegger
force-pushed
the
lsp-goto-location
branch
from
6dd80a3
to
4a1bf01
Compare
mfussenegger
force-pushed
the
lsp-goto-location
branch
from
4a1bf01
to
3bee3ab
Compare
MariaSolOs
approved these changes
Oct 20, 2024
done. Looks like this was generally not tested. |
Thx! LGTM |
This was referenced Oct 20, 2024
|
Is it intended that these methods no longer set tagstack? |
No that wasn't intentional. I missed that it did that. I'll follow up on re-adding that. |
mfussenegger
added a commit
to mfussenegger/neovim
that referenced
this pull request
Oct 24, 2024
Follow up to neovim#30877 Fixes neovim#30926
Done with #30927 |
This was referenced Oct 26, 2024
4 tasks
Julian
added a commit
to Julian/lean.nvim
that referenced
this pull request
Oct 29, 2024
I'd noticed the former was pretty useless as all it does is basically call the latter. Seems like now it's been officially deprecated upstream in 0.11. Refs: neovim/neovim#30877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Closes:
textDocument/definitiondoesn't sendcontexttoon_listhandler #26936 (but only provides bufnrand method)
Might fix: #30737