Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt to deprecated jump_to_location #3344

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

tris203
Copy link
Contributor

@tris203 tris203 commented Oct 27, 2024

Description

vim.lsp.util.jump_to_location was deprecated in neovim/neovim#30877
This replaces it with vim.lsp.util.show_document which jump_to_location uses anyways.

The underlying function is available in 0.9

There are also some associated type annotation changes.

I also changed the return to an empty table rather than nil for some lsp complaints although functionally it remains the same

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

gd's in 0.9, 0.10 and HEAD

Configuration:

  • Neovim version (nvim --version):
  • Operating system and version:

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@tris203
Copy link
Contributor Author

tris203 commented Oct 27, 2024

I tried to generate docs locally, it picked up some changes but CI still didn't like it.

@jamestrew jamestrew merged commit 85922dd into nvim-telescope:master Oct 29, 2024
22 of 24 checks passed
@jamestrew
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants