Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4433, Add PoolRpc::test_tx_pool_accept, check if the transaction can be accepted by TxPool #4435

Closed
wants to merge 1 commit into from
Closed

Backport #4433, Add PoolRpc::test_tx_pool_accept, check if the transaction can be accepted by TxPool #4435

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

Backport #4433

What problem does this PR solve?

Returns the result of transaction pool acceptance tests, indicating whether the raw transaction would be accepted by the transaction pool. The transaction will not be inserted into the transaction pool.

Related changes

  • Add test_tx_pool_accept for PoolRpc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec changed the base branch from develop to rc/v0.116.x April 24, 2024 07:06
@eval-exec eval-exec marked this pull request as ready for review April 24, 2024 07:06
@eval-exec eval-exec requested a review from a team as a code owner April 24, 2024 07:06
@eval-exec eval-exec requested review from quake and doitian April 24, 2024 07:06
@doitian
Copy link
Member

doitian commented Apr 24, 2024

WIll merge develop into rc2

@doitian doitian closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @doitian