-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Redis to Valkey and add Healthchecks #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasge
reviewed
Apr 19, 2024
tobiasge
approved these changes
Apr 19, 2024
The Redis containers in |
Merged
Hi netbox-docker release 3.0.0 is using Valkey 8.0, which is still a release candidate : https://github.com/valkey-io/valkey/releases
Shouldn't Netbox use Valkey 7.x in the meantime ? |
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
New Behavior
This PR removes the non-free Redis and uses Valkey instead, which is the FOSS fork of Redis backed by the Linux Foundation.
Additionally, it adds healthchecks to both instances and also to the postgres db.
Contrast to Current Behavior
We suggest our users to use proprietary software.
Discussion: Benefits and Drawbacks
I wasn't sure whether we should rename any reference to the term redis, which is a trademark. But this would lead to problems when migrating. I'm not even sure if a Docker volume can even be renamed.
Should we decide to not switch to Valkey just now, we should at least add the healthchecks. (They work for redis as well, just with
redis-cli
instead ofvalkey-cli
of course.)Regarding We suggest our users to use proprietary software.:
The irony that this project is called
netbox-docker
, and Docker is a proprietary software, is not entirely lost on me. Today, I would probably call the projectnetbox-container
. We could perhaps even rename the project, as the relevant container repositories don't contain the termnetbox-docker
. But that's something for another time.Changes to the Wiki
n/a
Proposed Release Note Entry
Replacing Redis with Valkey
Adding healthchecks to Valkey and PostgreSQL
Double Check
develop
branch.