Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply renovate patches and update the project to support netbox-docker 3.0.1 #17

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

jsenecal
Copy link
Contributor

@jsenecal jsenecal commented Sep 11, 2024

Breaking changes

  • Removal of the now unsupported netbox_napalm_* variables
  • Uses valkey instead of redis due to licence changes

Features

  • Replaces netbox_proxy_network_name (a string) with netbox_additionnal_network_names (a list) to allow for different scenarios
  • Updates the docker-compose file to add upstream health checks.

Fixes #16 and #6

Copy link
Owner

@wastrachan wastrachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing all of this work, I appreciate all of the updates and the generic re-implementation of external networks.

I'd like to understand the switch from Redis a little better. I'm aware of their license changes, as well as the impact they have on the SAAS ecosystem, as well as for various MSP uses. I also fully support the right of an individual to choose an alternative open source project when they disagree with a decision and when it suits their needs.

Is there something about the new Redis license that makes it incompatible with this project, or this project's license? Many of us rely on the stability and proven history of Redis in production workloads, and aren't yet ready to move to another offering that has not yet had ample time to prove it's development practices and stewardship. If there is an incompatibility, I'm of course happy to honor licenses and commit to removing Redis from this project, but if it's just preference- I'd prefer keeping things as they are, or perhaps exploring an option that would let the end user opt for Redis or Valkey as it fits their goals.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
templates/docker-compose.yml.j2 Outdated Show resolved Hide resolved
templates/docker-compose.yml.j2 Outdated Show resolved Hide resolved
templates/docker-compose.yml.j2 Outdated Show resolved Hide resolved
templates/docker-compose.yml.j2 Outdated Show resolved Hide resolved
@jsenecal
Copy link
Contributor Author

Is there something about the new Redis license that makes it incompatible with this project, or this project's license? Many of us rely on the stability and proven history of Redis in production workloads, and aren't yet ready to move to another offering that has not yet had ample time to prove it's development practices and stewardship. If there is an incompatibility, I'm of course happy to honor licenses and commit to removing Redis from this project, but if it's just preference- I'd prefer keeping things as they are, or perhaps exploring an option that would let the end user opt for Redis or Valkey as it fits their goals.

Under the new license, cloud service providers hosting Redis offerings will no longer be permitted to use the source code of Redis free of charge. For example, cloud service providers will be able to deliver Redis 7.4 only after agreeing to licensing terms with Redis, the maintainers of the Redis code. These agreements will underpin support for existing integrated solutions and provide full access to forthcoming Redis innovations.

This also means that a service provider cannot freely distribute a solution with a Redis component under this new licensing.

Valkey is a FOSS fork of Redis backed by the Linux Foundation.

This change also follows upstream decision to move away from Redis. netbox-community/netbox-docker#1203

/Additional only has one `n`/
@jsenecal jsenecal requested a review from wastrachan September 12, 2024 14:56
@wastrachan
Copy link
Owner

Is there something about the new Redis license that makes it incompatible with this project, or this project's license? Many of us rely on the stability and proven history of Redis in production workloads, and aren't yet ready to move to another offering that has not yet had ample time to prove it's development practices and stewardship. If there is an incompatibility, I'm of course happy to honor licenses and commit to removing Redis from this project, but if it's just preference- I'd prefer keeping things as they are, or perhaps exploring an option that would let the end user opt for Redis or Valkey as it fits their goals.

Under the new license, cloud service providers hosting Redis offerings will no longer be permitted to use the source code of Redis free of charge. For example, cloud service providers will be able to deliver Redis 7.4 only after agreeing to licensing terms with Redis, the maintainers of the Redis code. These agreements will underpin support for existing integrated solutions and provide full access to forthcoming Redis innovations.

This also means that a service provider cannot freely distribute a solution with a Redis component under this new licensing.

Valkey is a FOSS fork of Redis backed by the Linux Foundation.

This change also follows upstream decision to move away from Redis. netbox-community/netbox-docker#1203

Thanks, this is helpful. I generally undestand the ramifications of the new license-- but knowing that Netbox has switched offers me at least the assurance that Nextbox will be continuously tested with Valkey.

@wastrachan wastrachan merged commit b6dbd4e into wastrachan:master Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support netbox-docker 3.0
2 participants