Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show duplicates IP in another colour for shared role #1376

Closed
claudex opened this issue Jul 26, 2017 · 1 comment
Closed

Show duplicates IP in another colour for shared role #1376

claudex opened this issue Jul 26, 2017 · 1 comment

Comments

@claudex
Copy link

claudex commented Jul 26, 2017

Issue type: feature request

With the new IP role added (thanks for that), would it be possible to change the duplication check when displaying an IP ? I would like to show the warning in another colour the duplicate addresses if the role is to be shared among several interface (VIP, anycast, VRRP...). I still think that it is usefull to show the other duplicate IP to see where it is allocated.

Here is an exemple of what I think. If you think this is OK, I will work on a pull request with cleaner code.

(code in ipadress.html)

        {% if duplicate_ips_table.rows %}
                        {% if ipaddress.get_role_display == 'VIP' %}
                                {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='info' %}
                        {% else %}
                                {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='danger' %}
                        {% endif %}
        {% endif %}
@jeremystretch
Copy link
Member

I think it makes sense to simply ignore duplicate IPs with the "anycast" role, but for the rest of these you still want to know when you have duplicate IPs. For instance, you should typically only have one VRRP IP in a prefix, which is shared by multiple devices. (Note that we cannot currently map a VIP explicitly to multiple interfaces, though we'll probably implement something in the future.)

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants