Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hiding search box in menu bar #1397

Closed
awfki opened this issue Aug 4, 2017 · 15 comments
Closed

Stop hiding search box in menu bar #1397

awfki opened this issue Aug 4, 2017 · 15 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@awfki
Copy link

awfki commented Aug 4, 2017

Issue type: feature request

Python version: 2.7.5
NetBox version: 2.1.1

The search box in the menu bar (upper-right corner next to the login name) is hidden when the window is less than 1600 pixels wide. At 1200 pixels wide there still seems to be plenty of space for that box. That's a key UI element for my users so I'd love it if we could leave it visible as much as possible.
@jeremystretch
Copy link
Member

Could you please submit a pull request with the modified CSS you'd like to implement?

@awfki
Copy link
Author

awfki commented Aug 8, 2017

Created PR 1404.
#1404

@jeremystretch
Copy link
Member

jeremystretch commented Aug 8, 2017

The problem with this is that the search box gets bumped down a line with longer usernames (e.g. when email addresses are used as usernames).

@bellwood
Copy link
Contributor

bellwood commented Aug 9, 2017

I would say:

  1. at that breakpoint, provide an icon that when clicked gives search in a drop down

  2. when the navbar collapses, add search to the head of the menuing items

Would be similar to this:
https://bootsnipp.com/snippets/featured/navbar-search-add-on-bs-3

...but with the added dropdown for search at the larger breakpoint

If this is something agreeable I will make a UI PR

@jeremystretch
Copy link
Member

@bellwood sounds good to me.

@jeremystretch jeremystretch reopened this Aug 9, 2017
@bellwood
Copy link
Contributor

bellwood commented Aug 9, 2017

Will do

@bellwood
Copy link
Contributor

So some thoughts here... Being that we can't assume how long a username will be and therefore accommodate every installation, what if we simply moved the search out of the nav header and either:

  1. sticky a container wide search bar under the nav header that is always persistent

  2. move the search to an off-screen canvas that you can pull out when needed

In the spirit of keep things simple and universal, option 1 seems best, however I can see how some folks may not want to give up 50-ish pixels of vertical real-estate.

As a compromise for option 1 we could add an icon to the menu that toggles the visibility of the search box

Just wanted some further input before I make PR's without the input of other users.

@jeremystretch
Copy link
Member

jeremystretch commented Aug 10, 2017

The first option I think is too wasteful of screen space. I like the idea of an icon that pops down a little search box. It'd still be just one click if showing the dropdown autofocuses on the search field.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Aug 10, 2017
@bellwood
Copy link
Contributor

bellwood commented Aug 10, 2017 via email

@bellwood
Copy link
Contributor

Feedback on this, anyone?

@jeremystretch
Copy link
Member

@bellwood might make sense to have the search bar both embedded in the nav menu and as a dropdown, and only display one or the other depending on the screen size (so that the search bar appears to condense into a dropdown when the screen shrinks).

@awfki
Copy link
Author

awfki commented Aug 23, 2017 via email

@bellwood
Copy link
Contributor

I'd prefer condensing the username into an icon

That may honestly be preferable, then the search as it exists (with a change to the CSS media query to hide it) would natively collapse on its own...

Would be as simple as wrapping the username in a span that hides at the same collapse point as the rest of the menu

I'm all for keeping things simple

@traveler3468
Copy link

Im ok with the way things are to be honest. The global search doesnt need to be visible while viewing more specific data. As long as the search for the specific data is available then you dont need to global search. If youre searching globally then go back to the home page and search there.

@jeremystretch
Copy link
Member

This was addressed in 124878e

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants