Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add pictures/images/photos of racks/devices #152

Closed
Amfy opened this issue Jun 30, 2016 · 16 comments
Closed

Ability to add pictures/images/photos of racks/devices #152

Amfy opened this issue Jun 30, 2016 · 16 comments

Comments

@Amfy
Copy link

Amfy commented Jun 30, 2016

Add the ability to upload pictures and link this to racks and devices to assist during remote sessions. Racktables has this and it helps a lot during the daily operating duty

@afenioux
Copy link

afenioux commented Jul 8, 2016

More generally, it would be practical to be able to attach any type of file to any object.
Some may need to link pdf contract (or bills) to device or somewhere else

@rekeds
Copy link

rekeds commented Jul 8, 2016

yes, sounds good.
currently we use wiki for this.

@kefoster
Copy link

kefoster commented Jul 8, 2016

I like the idea of being able to upload pictures of the racks. However for other pieces like contracts/docs etc it would be nice to just be able to attach a URL/UNC that points to the location of the documents.

@JNR8
Copy link

JNR8 commented Jul 15, 2016

a vote from me on this.
Being able to upload images of whole racks to Rack object, builds to location objects and device images to specific devices would be very helpful. Device Templates could also hold a generic image of that type of device.

@martink2
Copy link

I would also cast my vote for device images, it would help visibility a lot compared to just the colored boxes in the rack view. Given our day to day operations i would suggest the following
three to be added to a device/device type:

  • Front view of the device (also used in the rack view)
  • Rear view of the device (also used in the rack view)
  • Port Description, technical drawing with detailed port descriptions (maybe shown on mouse over or a details page)

In our current solution we have the first two but missing the last which
often leads to cables ending up in the wrong physical port (no matter how detailed you
describe ge-0/0/0 on the device .. there is always room for interpretation)

@fltchr
Copy link

fltchr commented Aug 29, 2016

@martink2, curious, are the images of your actual devices, or stock images? Just wondering if they accurately represent installed modules and options. If the former, it seems like it would be a pain to collect images the correct size and quality needed to plug into the rack views.

@martink2
Copy link

Usually it's stock images, we rarely have to photograph something. Having the modules in would be a definite bonus but i would gladly settle for devices only.

@farewelldave
Copy link

I don't know the feasibility of this, but most vendors have a decent set of visio stencils, and I wonder if there would/could be a way too import a stencil file, which would generally be an entire product line/category, and skim the image from that stencil?

That may be too lofty or too hard to implement, so starting with a per device field for picture data for front/rear images would be nice. The technical drawing would be really nice on servers. i.e., multiple NICs on add-in cards that aren't necessarily ge0/1, ge0/2, etc.

@cstueckrath
Copy link

stencil support (or something similar) would be awesome, especially if the interfaces were usable as interactive objects

@zevlag
Copy link
Contributor

zevlag commented Jan 5, 2017

@jeremystretch Do you have ideas on how you'd like to see this implemented if someone were to begin work on code to contribute this feature?

@jeremystretch
Copy link
Member

@zevlag I was just pondering this yesterday, trying to determine how best to store the media files. Saving them to disk will require some additional configuration on the web server side and particular attention to filesystem permissions. This shouldn't be too complicated but will extend data outside of the database, so users will need to modify their backup and replication schemes to account for this.

Alternatively, we could store the files directly in the database. This isn't something I'd normally consider, but NetBox is typically a very low-traffic application, so I'm not too worried about the performance hit. Though it does, of course, greatly increase the size of the database. I'm open to suggestions.

@LukeDRussell
Copy link

I'd prefer it be in the database - ultimately the images are going to take up disk space somewhere and a simple backup procedure is nice. Also plus one for this feature.

@jeremystretch
Copy link
Member

Security is another consideration: We want to ensure that photos and other potentially sensitive media are not inadvertently exposed directly through the web frontend without the request being authenticated. This can be accomplished with either approach, but database storage removes the possibility of leakage due to web server misconfiguration.

@mkx32083
Copy link

mkx32083 commented Feb 6, 2017

I'm for the DB solution too.

@puck
Copy link

puck commented Feb 7, 2017

There are some projects (such as Request Tracker) which had stored assets in the database, but run into scaling issues. If possible then an abstraction layer would be preferable. This could allow storing in a DB, S3, files, whatever.

And if files are used, then you probably don't want them stored under the doc root for the web server. ;)

@martink2
Copy link

martink2 commented Feb 7, 2017

I have to agree with @puck, we did blob store inside a Postgres once and
it became a mess pretty quickly. I would suggest to have the db store a
url reference to the file. For convenience an upload / download / browse
function for locally stored images in a directory would be very much appreciated.

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests