Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for custom names for Identity Provider text in the Login link #15375

Closed
vmorris opened this issue Mar 8, 2024 · 5 comments · Fixed by #16732
Closed

Allow for custom names for Identity Provider text in the Login link #15375

vmorris opened this issue Mar 8, 2024 · 5 comments · Fixed by #16732
Assignees
@tobast
Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@vmorris
Copy link

vmorris commented Mar 8, 2024 •
edited
Loading

NetBox version

v3.7.3

Feature type

Change to existing functionality

Proposed functionality

Recently oidc was added to the auth backend (#14587) to make the login link more user friendly.

In the issue, @llamafilm also requested the ability to customize this text, as there are many different OIDC IdP. (#14587 (comment))

This request is to add that functionality to specify a custom name in the login link for any social login provider.

Use case

There are many different social IdPs and users will appreciate knowing which one they are going to be authenticating to.

Database changes

None

External dependencies

None
@vmorris vmorris added the type: feature Introduction of new functionality to the application label Mar 8, 2024
@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 8, 2024
@alehaa
Copy link
Contributor

alehaa commented Mar 8, 2024

IMHO this shouldn't be exclusive to OIDC. Defining a custom name for other social auth types like KeyCloak or SAML would be good, too.

@llamafilm
Copy link
Contributor

Agreed. @vmorris Can you edit this request to make it generic? I have a patch already, I can make a PR.

@vmorris vmorris changed the title Allow for custom OIDC Identity Provider text in the Login link Allow for custom names for Identity Provider text in the Login link Mar 10, 2024
@vmorris
Copy link
Author

vmorris commented Mar 10, 2024

@llamafilm okay, updated, thanks!

@llamafilm llamafilm mentioned this issue Mar 10, 2024
Closed
@abhi1693 abhi1693 added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Mar 10, 2024
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: accepted This issue has been accepted for implementation labels Apr 3, 2024
@jeremystretch jeremystretch added the complexity: medium Requires a substantial but not unusual amount of effort to implement label May 21, 2024
@tobast
Copy link
Contributor

tobast commented Jun 20, 2024

Hello,
I may submit a PR for this if you want.

@vmorris
Copy link
Author

vmorris commented Jun 21, 2024

@tobast yes please!

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jun 21, 2024
tobast added a commit to tobast/netbox that referenced this issue Jun 26, 2024
@tobast
SSO: allow overriding AUTH_BACKEND_ATTRS
99b09e6 
Fixes netbox-community#15375
@tobast tobast mentioned this issue Jun 26, 2024
Merged
jeremystretch added a commit that referenced this issue Jul 10, 2024
@jeremystretch
Changelog for #15375, #16357, #16760, #16838, #16867
6f3a2a5
@jeremystretch jeremystretch mentioned this issue Jul 26, 2024
Merged
jeremystretch added a commit that referenced this issue Jul 26, 2024
@jeremystretch
Changelog for #15375, #16357, #16760, #16838, #16867
5c272f8
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tobast tobast

Labels
complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
6 participants
@tobast @llamafilm @abhi1693 @alehaa @vmorris @jeremystretch