Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add REMOTE_AUTH_DISPLAYNAME setting #15393

Closed
wants to merge 1 commit into from

Conversation

llamafilm
Copy link
Contributor

Fixes: #15375

Add optional setting for REMOTE_AUTH_DISPLAYNAME. If set, it will override the remote auth provider name shown on the login page.

image

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not account for using multiple authentication backends. A much more flexible approach would be to allow an administrator to override the contents of AUTH_BACKEND_ATTRS on a per-backend basis.

@llamafilm
Copy link
Contributor Author

How is it possible to have multiple authentication backends? REMOTE_AUTH_BACKEND is a single string variable.

@jeremystretch
Copy link
Member

REMOTE_AUTH_BACKEND is a single string variable.

Correct, but ideally we should support multiple backends. (I thought there was an FR for this, but maybe not.) Also consider that the active backend may be changed.

@llamafilm
Copy link
Contributor Author

Changing the backend should work fine with this.

Since that feature hasn't been defined yet, I don't think it makes sense to add extra complexity here, guessing how it might be implemented. For example, someone might wants to use 2 different backends of the same type.

@jeremystretch
Copy link
Member

I'm sorry but this is not acceptable in its current form. Please extend it to allow overriding the values in AUTH_BACKEND_ATTRS as requested.

@jeremystretch
Copy link
Member

@llamafilm do you intend to continue working on this, or should we release you from the FR?

@llamafilm
Copy link
Contributor Author

I provided a very simple solution that works, and you haven't pointed out any problems with it. I'm not going to spend any more time on this to support some potential new use case that might be added in the future.

@jeremystretch
Copy link
Member

As I said above:

This change does not account for using multiple authentication backends.

I'll go ahead and close this out.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for custom names for Identity Provider text in the Login link
2 participants