-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add REMOTE_AUTH_DISPLAYNAME setting #15393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change does not account for using multiple authentication backends. A much more flexible approach would be to allow an administrator to override the contents of AUTH_BACKEND_ATTRS
on a per-backend basis.
How is it possible to have multiple authentication backends? |
Correct, but ideally we should support multiple backends. (I thought there was an FR for this, but maybe not.) Also consider that the active backend may be changed. |
Changing the backend should work fine with this. Since that feature hasn't been defined yet, I don't think it makes sense to add extra complexity here, guessing how it might be implemented. For example, someone might wants to use 2 different backends of the same type. |
I'm sorry but this is not acceptable in its current form. Please extend it to allow overriding the values in |
@llamafilm do you intend to continue working on this, or should we release you from the FR? |
I provided a very simple solution that works, and you haven't pointed out any problems with it. I'm not going to spend any more time on this to support some potential new use case that might be added in the future. |
As I said above:
I'll go ahead and close this out. |
Fixes: #15375
Add optional setting for
REMOTE_AUTH_DISPLAYNAME
. If set, it will override the remote auth provider name shown on the login page.