Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk editing of interface VLAN assignments #2160

Closed
jenslink opened this issue Jun 12, 2018 · 4 comments · Fixed by #3350
Closed

Bulk editing of interface VLAN assignments #2160

jenslink opened this issue Jun 12, 2018 · 4 comments · Fixed by #3350
Labels
status: accepted This issue has been accepted for implementation

Comments

@jenslink
Copy link

Issue type

[x] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.3
  • NetBox version: 2.3.3

Description

It would be nice if you could assign a VLAN to several interfaces at once. When going to the device view and selecting several interfaces and edit them I can change description, mode, ... but it would be nice so set the VLAN as well.
@lampwins
Copy link
Contributor

lampwins commented Jul 3, 2018

Just realized we pulled bulk edit of 802.1Q settings at the last minute but we never opened an issue to add it back.

My initial thought is to use the existing 802.1Q workflow for individual interfaces to build a new bulk edit view specifically for this purpose. I don't see a good way to reuse the existing bulk object edit view and we certainly should reuse the existing 802.1Q workflow.

@jeremystretch jeremystretch changed the title Set VLAN when changing severeal interfaces Bulk editing of interface VLAN assignments Jul 18, 2018
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Jul 18, 2018
@JNR8
Copy link

JNR8 commented Aug 15, 2018

I'd definitely like to see this. I am adding in lots of switches at the moment and each interface has the same config (for the most part). Adding them manually to each interface is sapping my sense of humor. If this is likely to turn up soon, I'll hang fire on the VLAN config side of things.

@lampwins lampwins mentioned this issue Dec 28, 2018
Closed
@jeremystretch jeremystretch added type: ui and removed type: feature Introduction of new functionality to the application labels May 2, 2019
@morten-starvik
Copy link

What happened to this feature request? The referenced issue just loops back to this one...

@netbox-community netbox-community deleted a comment from Wax-Trax Jun 27, 2019
@DanSheps
Copy link
Member

@morten-starvik The referenced issue is because that issue is a duplicate of this issue.

DanSheps added a commit to DanSheps/netbox that referenced this issue Jul 17, 2019
@DanSheps
Fixes netbox-community#3341 - Added in-line vlan editing
789cb61 
Fixes netbox-community#2160 - Added bulk vlan editing

Consequential behaviour changes

* APISelect can now take "full=True" to return a non-brief set
* Select2 will no group by "group & site, group, site, global" if full=True is set in APISelect
@DanSheps DanSheps mentioned this issue Jul 17, 2019
Merged
DanSheps added a commit that referenced this issue Sep 6, 2019
@DanSheps
Add in in-line vlan editing and Bulk vlan editing (#3350)
9c6dbd7 
* Fixes #3341 - Added in-line vlan editing
* Fixes #2160 - Added bulk vlan editing

Inconsequential behaviour changes:

* APISelect can now take "full=True" to return a non-brief set
* Select2 will no group by "group & site, group, site, global" if full=True is set in APISelect
@jeremystretch jeremystretch mentioned this issue Sep 19, 2019
Merged
marcoceppi pushed a commit to vapor-ware/netbox that referenced this issue Sep 25, 2019
@DanSheps @marcoceppi
Add in in-line vlan editing and Bulk vlan editing (netbox-community#3350
795f86c 
)

* Fixes netbox-community#3341 - Added in-line vlan editing
* Fixes netbox-community#2160 - Added bulk vlan editing

Inconsequential behaviour changes:

* APISelect can now take "full=True" to return a non-brief set
* Select2 will no group by "group & site, group, site, global" if full=True is set in APISelect
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in in-line vlan editing and Bulk vlan editing DanSheps/netbox
6 participants
@lampwins @jenslink @JNR8 @DanSheps @jeremystretch @morten-starvik