Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for 32-bit ASNs #268

Closed
daknob opened this issue Jul 12, 2016 · 1 comment
Closed

Support for 32-bit ASNs #268

daknob opened this issue Jul 12, 2016 · 1 comment
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@daknob
Copy link

daknob commented Jul 12, 2016

Currently adding a 32-bit ASN throws an error message in the "Add Site" page:

Ensure this value is less than or equal to 2147483647.

However you are using a signed integer in this check. The BGP ASN can be a 32-bit unsigned integer, which means it can accept values from 0 to 4294967296. This error can render some ASNs unmanageable. Although RIRs have not allocated an ASN this large yet, the 32-bit ASN Private Range (4200000000 - 4294967294) is not supported.
@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jul 12, 2016
@jeremystretch
Copy link
Member

The asn field is currently defined as a PositiveIntegerField which as @daknob points out behaves as a signed integer. We might need a custom field to support unsigned 32-bit integers.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application and removed type: feature Introduction of new functionality to the application labels Jul 13, 2016
@jeremystretch jeremystretch mentioned this issue Jul 14, 2016
Merged
if-fi pushed a commit to if-fi/netbox that referenced this issue Oct 1, 2016
@jeremystretch
Fixes netbox-community#268: Added support for full 32-bit ASN space
a2cfa7c
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daknob @jeremystretch