Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LC/APC, SC/APC and LSH/APC port types #2890

Closed
gdelafond opened this issue Feb 14, 2019 · 2 comments
Closed

Add LC/APC, SC/APC and LSH/APC port types #2890

gdelafond opened this issue Feb 14, 2019 · 2 comments
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@gdelafond
Copy link
Contributor

Environment

  • Python version: 3.5.3
  • NetBox version: 2.5.6

Proposed Functionality

Add LC/APC, SC/APC and LSH/APC port types.

Use Case

We need to track LC PC/APC and SC PC/APC port type on patch panel.

Database Changes

None.

External Dependencies

None.

@jeremystretch
Copy link
Member

Please revise your request to specify the exact types you're proposing and include justification for why the existing types aren't sufficient.

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Feb 15, 2019
@gdelafond
Copy link
Contributor Author

We have patch panel with 4 differents port types: LC/PC, LC/APC, SC/PC and SC/APC.

Currently in Netbox there is already LC and SC port types. LC is usually a shortcut for LC/PC and SC for SC/PC. That's why I want to add LC/APC and SC/APC.

As I know that LSH/APC exists too (cf #2569), I have included it in my PR.

So this request and the PR is to add the following port types :

  • LC/APC
  • SC/APC
  • LSH/APC

If you want, in addition I can rename existing LC to LC/PC and existing SC to LC/PC.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application and removed status: revisions needed This issue requires additional information to be actionable labels Feb 20, 2019
jeremystretch added a commit that referenced this issue Feb 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants