Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude /metrics from LOGIN_REQUIRED #3123

Closed
larsweiler opened this issue Apr 30, 2019 · 1 comment
Closed

Exclude /metrics from LOGIN_REQUIRED #3123

larsweiler opened this issue Apr 30, 2019 · 1 comment
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@larsweiler
Copy link

Environment

  • Python version: 3.7.3
  • NetBox version: 2.6-beta1

Proposed Functionality

With Prometheus Metrics from #3104 enabled and also LOGIN_REQUIRED enabled, the URL /metrics will redirect to the login page. This merge request will exclude /metrics from LOGIN_REQUIRED in the same way as /api is excluded.

Use Case

For monitoring with Prometheus a user login on a webpage is not feasible. Prometheus should access the metrics without login.

Database Changes

None.

External Dependencies

None.
@jeremystretch jeremystretch added beta status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels Apr 30, 2019
@larsweiler larsweiler mentioned this issue Apr 30, 2019
Merged
@lampwins
Copy link
Contributor

Closed in #3124

jeremystretch added a commit that referenced this issue Apr 30, 2019
@jeremystretch
Changelog for #3123
73927d2
@jeremystretch jeremystretch mentioned this issue Jun 20, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larsweiler @lampwins @jeremystretch