Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login link does not retain query parameters #3228

Closed
DanSheps opened this issue May 30, 2019 · 0 comments
Closed

Login link does not retain query parameters #3228

DanSheps opened this issue May 30, 2019 · 0 comments
Assignees
@DanSheps
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@DanSheps
Copy link
Member

Environment

  • Python version: 3.6
  • NetBox version: 2.5.12

Steps to Reproduce

  1. Navigate to /dcim/devices?site=Site while logged out
  2. Login

Expected Behavior

The ?site=Site (or any additional query parameters) will be preserved after logon

Observed Behavior

The ?site=Site is stripped
@DanSheps DanSheps added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels May 30, 2019
@DanSheps DanSheps self-assigned this May 30, 2019
@jeremystretch jeremystretch changed the title Login Middleware not passing full query string to next= parameter Login link does not retain query parameters May 30, 2019
DanSheps added a commit that referenced this issue May 30, 2019
@DanSheps
Fix #3228 - Send full path info instead of just path info and urlenco…
a11b33d 
…de said path info
DanSheps added a commit to DanSheps/netbox that referenced this issue May 30, 2019
@DanSheps
Fix netbox-community#3228 - UrlEncode full path for next if not on lo…
814c50f 
…gon page

Include the full path for the ?next= variable in login links if we are not on the logon page.
Additionally include next for post requests that have the next variable set (will only come from the login page itself generally)
@jeremystretch jeremystretch mentioned this issue May 31, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanSheps DanSheps

Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanSheps