Changelog retention time not shown in UI when set to Indefinite #3573
Labels
status: accepted
This issue has been accepted for implementation
type: bug
A confirmed report of unexpected behavior in the application
Environment
Steps to Reproduce
CHANGELOG_RETENTION = 0
in confighttp://localhost/extras/changelog/
Expected Behavior
Text
Changelog retention: Indefinite
to be visible/seenObserved Behavior
No text/div is rendered
Cause
When setting the variable to
0
to indicate Indefinite time, the if check that checks if the div and text should be rendered is done in sucha way that it evaluates toFalse
if the value is0
and the output is not rendered.https://github.com/netbox-community/netbox/blob/develop/netbox/templates/extras/objectchange_list.html#L12
Possible solution is to change the if check to this, it is not good/optimal, but it does the job and the text is again rendered as the expected text.
{% if settings.CHANGELOG_RETENTION >= 0 %}
References
#3264
#3368
The text was updated successfully, but these errors were encountered: