Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining "Search" and "Filter" for IP Addresses #841

Closed
candlerb opened this issue Jan 23, 2017 · 1 comment
Closed

Combining "Search" and "Filter" for IP Addresses #841

candlerb opened this issue Jan 23, 2017 · 1 comment
Labels
type: feature Introduction of new functionality to the application

Comments

@candlerb
Copy link
Contributor

Perhaps I am being dense here, but if I go to /ipam/ip-addresses/ I am unable to search for a keyword within a filtered range.

In the Filter box it says "Search within (Prefix)", which to me implies that it should be possible to do a keyword search within the prefix.

To replicate:

  • In Search box, enter some text e.g. "mon"
  • In Filter > Search Within, enter a prefix e.g. "192.168.7.0/24"
  • If I click the magnifying glass next to the Search box, I get all hosts containing "mon" (not filtered to prefix)
  • If I click the "Apply" button at the bottom of the Filter area, I get all hosts in 192.168.7.0/24 (not filtered to "mon")

However, it is possible to do the search I want if I construct the URL manually: /ipam/ip-addresses/?parent=192.168.7.0%2F24&q=mon. This would be a useful search to do from the UI.

If Search and Filter are intended to be exclusive (and I note they are within separate bounding rectangles), maybe the wording could be made clearer, e.g. "Addresses within" rather than "Search within"

Clients tested under OSX 10.11, all same behaviour:

  • Chrome 55
  • Safari
  • Firefox 50.1.0
@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jan 24, 2017
@jeremystretch
Copy link
Member

The two panels on the side each contain a separate form, the first being a single-field keyword search (q) and the second being a set of fields derived from the model's FilterForm. These can be combined by adding the q query to the FilterForm. (For all NetBox objects, not just prefixes.)

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants