Enhance LDAP documentation #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporating @marvnrawley's enhancements from #518
Carbenium
approved these changes
May 8, 2017
|
I'm still not able to get Windows LDAP working. |
jeremystretch
requested changes
May 17, 2017
docs/installation/ldap.md
Outdated
| @@ -99,3 +103,17 @@ AUTH_LDAP_FIND_GROUP_PERMS = True | |||
| AUTH_LDAP_CACHE_GROUPS = True | |||
| AUTH_LDAP_GROUP_CACHE_TIMEOUT = 3600 | |||
| ``` | |||
|
|
|||
| !!! info | |||
| "is_active" - you must map all users to at least this group if you want their account to be treated as enabled. Without this, your users cannot log in. | |||
There was a problem hiding this comment.
Please capitalize the first word in each sentence for these descriptions
docs/installation/ldap.md
Outdated
|
|
||
| !!! info | ||
| It is also possible map user attributes to Django attributes: | ||
| AUTH_LDAP_USER_ATTR_MAP = { |
There was a problem hiding this comment.
Probably want to wrap this in a code block and ensure proper indentation
|
Pinging @bellwood - Are you available to make these changes? |
|
Been burried lately - will attempt to get a revised PR this week
|
Capitalization
Wrap code in code block
|
Sorry for the late edits on this - been all over the place lately Thanks for the feedback =) |
lampwins
pushed a commit
to lampwins/netbox
that referenced
this pull request
Oct 13, 2017
Enhance LDAP documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating @marvnrawley LDAP enhancements from #518