-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8984 Allow script log to be filtered #16446
Conversation
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LogLevelChoices.LOG_DEFAULT: 0, | ||
LogLevelChoices.LOG_DEBUG: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on the distinction between debug
and default
: Debug is the lowest-ranked level, so shouldn't that be the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing LogLevelChoices has default defined so it needs to be mapped, we could filter and remove it from the dropdown but I included it because it is already existing. If we removed it from LogLevelChoices then we would need a migration script to convert old script runs to remove it.
Fixes: #8984
Added a chit to show log level filter: