-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8984 Allow script log to be filtered #16446
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d6a7ba1
8984 filter by script log level
arthanson 3d7a5bf
8984 filter log list
arthanson 0e163e0
8984 add dropdown
arthanson 8a0a3e1
8984 add dropdown
arthanson d3f3a56
8984 fix button color
arthanson a8d94c3
Update netbox/extras/views.py
arthanson ca6de26
Merge branch 'feature' into 8984-script-log
arthanson e77b5d2
8984 review changes
arthanson 253a4cf
8984 review changes
arthanson db838e0
8984 review changes
arthanson ae28d32
Merge branch 'feature' into 8984-script-log
jeremystretch 428dd15
Clean up log threshold selector
jeremystretch 13f9834
Merge branch 'feature' into 8984-script-log
arthanson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on the distinction between
debug
anddefault
: Debug is the lowest-ranked level, so shouldn't that be the default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing LogLevelChoices has default defined so it needs to be mapped, we could filter and remove it from the dropdown but I included it because it is already existing. If we removed it from LogLevelChoices then we would need a migration script to convert old script runs to remove it.