#2029 add port and transport napalm fields in platform model #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the approach but per my comment on #2029 let's use a single JSON field instead to allow more flexibility. Feel free to resubmit this PR if you want to make the necessary changes. |
jeremystretch
added
the
status: revisions needed
|
@ChrisdAutume Are you resubmitting this PR with the proposed change? |
|
#2029 has been implemented |
jeremystretch
removed
the
status: revisions needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #2029, ability to define port and transport parameters for napalm driver.
Fixes: